appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: Grouping & reorganisation of Property Pane

Open aswathkk opened this issue 2 years ago • 5 comments

Description

Removes feature flag for Property pane grouping and reorganisation

Fixes #15296

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

TODO

  • [ ] Fix Cypress tests
  • [ ] Remove feature-flag related code from Server
  • [ ] Address #15811
  • [ ] Visual changes of property pane

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

aswathkk avatar Aug 05 '22 09:08 aswathkk

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Sep 3, 2022 at 11:07AM (UTC)

vercel[bot] avatar Aug 05 '22 09:08 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Aug 05 '22 09:08 github-actions[bot]

/ok-to-test sha=042fa35

aswathkk avatar Aug 05 '22 09:08 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2802758102. Workflow: Appsmith External Integration Test Workflow. Commit: 042fa35. PR: 15768.

github-actions[bot] avatar Aug 05 '22 09:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2802758102. Commit: 042fa35. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1332.83 1548.56 1286.05 1226.55 1092.96 1286.05 1297.39 12.86 11.50
painting 16.39 9.52 9.2 7.34 5.56 9.2 9.6 42.81 38.33
rendering 1001.83 1158.91 1106.62 936.23 847.24 1001.83 1010.17 12.47 11.16
SELECT_WIDGET_SELECT_OPTION
scripting 219.31 303.77 236.39 184.2 194.02 219.31 227.54 20.80 18.60
painting 10.67 6.81 5.77 6.07 8.87 6.81 7.64 27.23 24.35
rendering 366.9 409.8 425.9 352.64 325.81 366.9 376.21 10.94 9.79

github-actions[bot] avatar Aug 05 '22 10:08 github-actions[bot]

/ok-to-test sha=aa0fd0e

aswathkk avatar Aug 10 '22 18:08 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2835253684. Workflow: Appsmith External Integration Test Workflow. Commit: aa0fd0e. PR: 15768.

github-actions[bot] avatar Aug 10 '22 19:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2835253684. Commit: aa0fd0e. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1095.26 1151.94 1066.11 1146.42 1198.24 1146.42 1131.59 4.57 4.09
painting 7.11 10.95 9.25 8.39 12.58 9.25 9.66 22.26 19.88
rendering 858.15 924.43 813.76 929.7 870.74 870.74 879.36 5.51 4.93
SELECT_WIDGET_SELECT_OPTION
scripting 155.93 156.74 164.86 172.24 172.71 164.86 164.5 4.91 4.40
painting 4.94 2.7 8.38 11.49 4.33 4.94 6.37 55.42 49.61
rendering 295.5 328.04 317.58 321.51 341.47 321.51 320.82 5.24 4.69

github-actions[bot] avatar Aug 10 '22 20:08 github-actions[bot]

/ok-to-test sha=cf7e0c4

aswathkk avatar Aug 15 '22 05:08 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2858683056. Workflow: Appsmith External Integration Test Workflow. Commit: cf7e0c4. PR: 15768.

github-actions[bot] avatar Aug 15 '22 05:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2858683056. Commit: cf7e0c4. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1061.07 1090.19 1017.34 1045.77 1050.66 1050.66 1053.01 2.50 2.24
painting 6.76 4.56 4.5 8.95 7.2 6.76 6.39 29.58 26.45
rendering 791.82 821.13 797.63 811.58 814.7 811.58 807.37 1.51 1.35
SELECT_WIDGET_SELECT_OPTION
scripting 146.29 155.52 159.07 155.67 164.9 155.67 156.29 4.33 3.87
painting 5.06 3.13 12.44 3.67 6.48 5.06 6.16 60.88 54.38
rendering 299.98 309.61 296.25 311.66 311.46 309.61 305.79 2.35 2.10

github-actions[bot] avatar Aug 15 '22 06:08 github-actions[bot]

/ok-to-test sha=49689de

aswathkk avatar Aug 15 '22 08:08 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2859335656. Workflow: Appsmith External Integration Test Workflow. Commit: 49689de. PR: 15768.

github-actions[bot] avatar Aug 15 '22 08:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2859335656. Commit: 49689de. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1047.44 1100.46 1050.93 1053.52 1063.61 1053.52 1063.19 2.04 1.82
painting 4.53 6.14 9.05 12.49 16.18 9.05 9.68 48.86 43.70
rendering 1104.6 1121.03 1102.36 1108.32 1082.3 1104.6 1103.72 1.27 1.13
SELECT_WIDGET_SELECT_OPTION
scripting 168.03 232.64 169.16 157.55 179.65 169.16 181.41 16.37 14.64
painting 5.22 2.97 6.45 10.91 2.44 5.22 5.6 60.54 54.11
rendering 300.05 296.74 297.24 298.82 301.31 298.82 298.83 0.64 0.57

github-actions[bot] avatar Aug 15 '22 08:08 github-actions[bot]

/ok-to-test sha=2efd771

aswathkk avatar Aug 18 '22 04:08 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2879860766. Workflow: Appsmith External Integration Test Workflow. Commit: 2efd771. PR: 15768.

github-actions[bot] avatar Aug 18 '22 04:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2879860766. Commit: 2efd771. Results:

Click to view performance test results

Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)

github-actions[bot] avatar Aug 18 '22 04:08 github-actions[bot]

/ok-to-test sha=c7b45df

aswathkk avatar Aug 19 '22 06:08 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2887416147. Workflow: Appsmith External Integration Test Workflow. Commit: c7b45df. PR: 15768.

github-actions[bot] avatar Aug 19 '22 06:08 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2887416147. Workflow: Appsmith External Integration Test Workflow. Commit: c7b45df. PR: 15768.

github-actions[bot] avatar Aug 19 '22 13:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2887416147. Commit: c7b45df. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 293.53 265.52 311.39 280.87 275.26 280.87 285.31 16.08 6.22 5.57
painting 3.23 3.61 3.58 4.74 4.16 3.61 3.86 39.12 15.28 13.73
rendering 100.95 99.55 101.89 102.2 101.23 101.23 101.16 2.62 1.02 0.91
BIND_TABLE_DATA
scripting 1343.34 1184.02 1178.44 1171.41 1200.41 1184.02 1215.52 14.14 5.94 5.32
painting 13.46 14.15 12.9 15.59 17.24 14.15 14.67 29.58 11.93 10.70
rendering 764.8 783.24 765.29 778.11 767.84 767.84 771.86 2.39 1.08 0.97
CLICK_ON_TABLE_ROW
scripting 758.37 843.91 820.01 816.64 843.41 820.01 816.47 10.48 4.27 3.82
painting 12.1 9.25 9.43 8.06 11.13 9.43 9.99 40.44 16.12 14.41
rendering 281.51 294.94 312.43 298.58 291.14 294.94 295.72 10.46 3.82 3.42
UPDATE_POST_TITLE
scripting 1860.87 1215.36 1266.18 1257.07 1195.63 1257.07 1359.02 48.95 20.75 18.56
painting 11.89 16.68 19.75 18.13 13.35 16.68 15.96 49.25 20.55 18.36
rendering 421.78 425.18 436.33 432.24 411.74 425.18 425.45 5.78 2.25 2.01
OPEN_MODAL
scripting 500.67 512.67 511.91 517.57 1003.31 512.67 609.23 82.50 36.18 32.36
painting 9.07 13.72 12.37 8.52 10.36 10.36 10.81 48.10 20.35 18.22
rendering 500.09 512.08 506.78 514.6 512.18 512.08 509.15 2.85 1.14 1.02
CLOSE_MODAL
scripting 305.28 313.64 281.74 295.1 286.22 295.1 296.4 10.76 4.45 3.98
painting 8.47 10.22 4.11 10.41 4.3 8.47 7.5 84.00 41.33 37.07
rendering 316.89 345.88 314.4 323.24 319.43 319.43 323.97 9.72 3.91 3.50
SELECT_WIDGET_MENU_OPEN
scripting 1303.7 1222.5 1146.63 1137.16 1112.97 1146.63 1184.59 16.10 6.60 5.90
painting 6.05 11.08 4.7 10.61 7.78 7.78 8.04 79.35 34.70 30.97
rendering 1348.45 1349.86 1189.24 1192.47 1180.07 1192.47 1252.02 13.56 7.09 6.34
SELECT_WIDGET_SELECT_OPTION
scripting 175.52 175.56 151.61 153.97 156.32 156.32 162.6 14.73 7.34 6.56
painting 8.14 5.7 3.32 4.58 3.11 4.58 4.97 101.21 41.45 37.02
rendering 341.04 347.31 316.1 321.04 320.8 321.04 329.26 9.48 4.23 3.79

github-actions[bot] avatar Aug 19 '22 14:08 github-actions[bot]

/ok-to-test sha=016b88b

aswathkk avatar Aug 22 '22 03:08 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2901034736. Workflow: Appsmith External Integration Test Workflow. Commit: 016b88b. PR: 15768.

github-actions[bot] avatar Aug 22 '22 03:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2901034736. Commit: 016b88b. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_WIDGET_MENU_OPEN
scripting 1017.93 1022.72 1071.88 1004.38 1018.31 1018.31 1027.04 6.57 2.53 2.26
painting 4.89 4.52 4.02 6.4 5.05 4.89 4.98 47.79 17.87 16.06
rendering 1110.86 1111.64 1081.74 1097.85 1107.77 1107.77 1101.97 2.71 1.14 1.02
SELECT_WIDGET_SELECT_OPTION
scripting 139.54 140.39 143.43 143.01 154.89 143.01 144.25 10.64 4.28 3.83
painting 3.65 3.68 2.11 3.8 4.27 3.68 3.5 61.71 23.43 20.86
rendering 302.21 299.79 294.62 291.74 293.92 294.62 296.46 3.53 1.47 1.32
SELECT_CATEGORY
scripting 288.61 280.41 287.8 295.99 297.02 288.61 289.97 5.73 2.34 2.09
painting 3.54 4.26 4.09 4.38 4.16 4.16 4.09 20.54 7.82 7.09
rendering 101.65 100.77 99.99 102.24 108.69 101.65 102.67 8.47 3.38 3.03
BIND_TABLE_DATA
scripting 1179.48 1211.86 1213.19 1183.01 1229.06 1211.86 1203.32 4.12 1.77 1.58
painting 13.82 16.6 16.8 12.99 23.81 16.6 16.8 64.40 25.36 22.68
rendering 757.82 774.55 800.02 754.26 786.58 774.55 774.65 5.91 2.49 2.22
CLICK_ON_TABLE_ROW
scripting 760.89 803.49 822.43 867.23 827.57 822.43 816.32 13.03 4.74 4.24
painting 14.98 21.29 9.63 10.29 9.41 10.29 13.12 90.55 38.87 34.76
rendering 291.73 295.4 288.18 295.32 288.56 291.73 291.84 2.47 1.20 1.07
UPDATE_POST_TITLE
scripting 1358.99 1303.53 1236.94 1264.42 1241.39 1264.42 1281.05 9.53 3.98 3.56
painting 15.45 16.07 14.06 14.5 12.88 14.5 14.59 21.86 8.50 7.61
rendering 441.12 445.54 433.35 430.31 434.79 434.79 437.02 3.48 1.41 1.27
OPEN_MODAL
scripting 519.36 505.78 489.27 897.3 511.09 511.09 584.56 69.80 29.97 26.80
painting 14.01 12.13 8.9 8.93 11.01 11.01 11 46.45 19.82 17.73
rendering 497.09 494.34 482.02 493.5 496.92 494.34 492.77 3.06 1.26 1.13
CLOSE_MODAL
scripting 289.67 306.86 291.46 321.41 744.05 306.86 390.69 116.30 50.67 45.32
painting 3.98 3.84 7.26 4.42 5.61 4.42 5.02 68.13 28.49 25.50
rendering 318.41 320.2 320.36 327.3 331 320.36 323.45 3.89 1.68 1.50

github-actions[bot] avatar Aug 22 '22 04:08 github-actions[bot]

/ok-to-test sha=fbd0e68

aswathkk avatar Aug 23 '22 13:08 aswathkk

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2911744113. Workflow: Appsmith External Integration Test Workflow. Commit: fbd0e68. PR: 15768.

github-actions[bot] avatar Aug 23 '22 13:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2911744113. Commit: fbd0e68. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 338.92 310.44 285.73 1132.61 334.51 334.51 480.44 176.27 76.01 67.99
painting 3.43 4.94 10.68 3.96 3.56 3.96 5.31 136.53 57.63 51.41
rendering 113.03 106.57 103.61 119.2 112.07 112.07 110.9 14.06 5.46 4.89
BIND_TABLE_DATA
scripting 1521.07 1502.7 1535.27 1594.33 1526.91 1526.91 1536.06 5.97 2.26 2.02
painting 17.06 9.92 13.99 22.72 19.82 17.06 16.7 76.65 29.88 26.71
rendering 476.57 416.05 447.21 498.14 474.31 474.31 462.46 17.75 6.84 6.12
CLICK_ON_TABLE_ROW
scripting 818.22 885.45 838.6 1231.99 956.17 885.45 946.09 43.73 17.80 15.92
painting 16.11 14.75 9.22 19.55 11.76 14.75 14.28 72.34 27.87 24.93
rendering 321.41 305.11 323.34 333.48 322.92 322.92 321.25 8.83 3.18 2.85
UPDATE_POST_TITLE
scripting 1490.83 1295.26 1292.56 1561.11 1491.27 1490.83 1426.21 18.83 8.70 7.78
painting 15.26 12.63 14.35 18.05 16.06 15.26 15.27 35.49 13.16 11.79
rendering 477.35 439.42 453.46 518.5 497.36 477.35 477.22 16.57 6.71 6.00
OPEN_MODAL
scripting 638.89 481.45 500.82 566.79 536.58 536.58 544.91 28.89 11.37 10.17
painting 8.76 9.57 7.64 12.45 10.12 9.57 9.71 49.54 18.43 16.58
rendering 591.04 495.39 509.47 546.29 545.11 545.11 537.46 17.80 6.94 6.21
CLOSE_MODAL
scripting 298.41 300.58 298.07 817.79 313.41 300.58 405.65 128.12 56.82 50.82
painting 4.41 4.08 3.99 5.29 4.42 4.41 4.44 29.28 11.49 10.36
rendering 337.05 329.09 322.85 366.05 336.48 336.48 338.3 12.77 4.90 4.38
SELECT_WIDGET_MENU_OPEN
scripting 1200.65 1111.81 1190.1 1215.19 1103.73 1190.1 1164.3 9.57 4.50 4.03
painting 7.04 5.29 10.09 5.15 4.63 5.29 6.44 84.78 34.63 31.06
rendering 1298.31 1264.61 1265.79 1314.41 1244.46 1265.79 1277.52 5.48 2.21 1.98
SELECT_WIDGET_SELECT_OPTION
scripting 150.61 143.58 171.1 157.56 155.41 155.41 155.65 17.68 6.53 5.84
painting 10.12 8.89 4.61 6.75 6 6.75 7.27 75.79 30.54 27.37
rendering 313.19 310.18 313.75 310.88 314.5 313.19 312.5 1.38 0.60 0.54

github-actions[bot] avatar Aug 23 '22 15:08 github-actions[bot]

/ok-to-test sha=fd3dba3

NandanAnantharamu avatar Aug 23 '22 16:08 NandanAnantharamu

/ok-to-test sha=fd3dba3

NandanAnantharamu avatar Aug 23 '22 16:08 NandanAnantharamu

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2913251029. Workflow: Appsmith External Integration Test Workflow. Commit: fd3dba3. PR: 15768.

github-actions[bot] avatar Aug 23 '22 16:08 github-actions[bot]