appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: Migrate design system components import to design-system repo - I

Open albinAppsmith opened this issue 2 years ago • 13 comments

Description

This PR has changed the import of following components to design-system repository.

  • Icon
  • Button
  • Breadcrumbs
  • EmojiPicker
  • EmojiReaction
  • AppIcon
  • Menu Item
  • Icon Selector
  • Scroll Indicator fixes #15518
  • Text Input fixes https://github.com/appsmithorg/appsmith/issues/15516
  • Label with Tooltip fixes https://github.com/appsmithorg/appsmith/issues/15515
  • Checkbox fixes https://github.com/appsmithorg/appsmith/issues/15492

Fixes #15561

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested in local

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

albinAppsmith avatar Aug 01 '22 07:08 albinAppsmith

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Aug 19, 2022 at 0:18AM (UTC)

vercel[bot] avatar Aug 01 '22 07:08 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 37 seconds (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Aug 02 '22 09:08 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 10 seconds (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Aug 02 '22 10:08 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 27 minutes (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Aug 02 '22 10:08 vercel[bot]

/ok-to-test sha=7761e5d

albinAppsmith avatar Aug 04 '22 07:08 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2794961071. Workflow: Appsmith External Integration Test Workflow. Commit: 7761e5d. PR: 15562.

github-actions[bot] avatar Aug 04 '22 07:08 github-actions[bot]

/ok-to-test sha=5ef09dc

albinAppsmith avatar Aug 04 '22 12:08 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2796651070. Workflow: Appsmith External Integration Test Workflow. Commit: 5ef09dc. PR: 15562.

github-actions[bot] avatar Aug 04 '22 12:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2796651070. Commit: 5ef09dc. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1113.58 1158.03 1076.82 1048.51 1092.7 1092.7 1097.93 3.75 3.35
painting 13 7.38 13.01 13.43 6.79 13 10.72 31.06 27.80
rendering 848.49 899 846.51 844.8 874.12 848.49 862.58 2.74 2.45
SELECT_WIDGET_SELECT_OPTION
scripting 165.51 154.67 146.25 181.45 156.12 156.12 160.8 8.34 7.46
painting 2.16 3.36 15.89 2.36 5.89 3.36 5.93 97.13 86.85
rendering 306.46 298.13 306.82 311.23 312.91 306.82 307.11 1.87 1.67

github-actions[bot] avatar Aug 04 '22 13:08 github-actions[bot]

/ok-to-test sha=ef743fa

albinAppsmith avatar Aug 05 '22 11:08 albinAppsmith

/ok-to-test sha=2f7df68

tanvibhakta avatar Aug 09 '22 04:08 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2822710567. Workflow: Appsmith External Integration Test Workflow. Commit: 2f7df68. PR: 15562.

github-actions[bot] avatar Aug 09 '22 04:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2822710567. Commit: 2f7df68. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1012.98 1012.79 1082.24 1034.52 1045.07 1034.52 1037.52 2.76 2.47
painting 10.95 5.94 9.1 10.06 7.4 9.1 8.69 23.25 20.83
rendering 823.19 805.04 824.57 797.89 818.44 818.44 813.83 1.45 1.30
SELECT_WIDGET_SELECT_OPTION
scripting 182.46 149.5 149.74 151.02 162 151.02 158.94 8.89 7.95
painting 2.32 7.56 3.75 2.6 3.45 3.45 3.94 53.55 47.97
rendering 305.59 299.28 294.33 303.24 299.58 299.58 300.4 1.43 1.28

github-actions[bot] avatar Aug 09 '22 05:08 github-actions[bot]

/ok-to-test sha=17efa41

tanvibhakta avatar Aug 13 '22 13:08 tanvibhakta

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2852104606. Workflow: Appsmith External Integration Test Workflow. Commit: 17efa41. PR: 15562.

github-actions[bot] avatar Aug 13 '22 13:08 github-actions[bot]

Below are the issues observed in this PR:

  1. Checkbox Component:
  • Checkbox for any custom column, save/discard column & all columns other than Plain text & number is not appropriate. Screenshot 2022-08-16 at 11.03.04 AM.png
  1. Button Component:
  • The colour of the Chart widget - Add Series button is darker in DP when compared to prod/release. Screenshot 2022-08-16 at 11.05.01 AM.png

@albinAppsmith, @tanvibhakta

shadabbuchh avatar Aug 16 '22 05:08 shadabbuchh

/ok-to-test sha=af753f9

albinAppsmith avatar Aug 17 '22 04:08 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2872782101. Workflow: Appsmith External Integration Test Workflow. Commit: af753f9. PR: 15562.

github-actions[bot] avatar Aug 17 '22 04:08 github-actions[bot]

Issues in the Dropdown component:

  • The indentation for options in a dropdown is not appropriate. Please note that this issue is present in all impact areas of the Dropdown component. Screenshot 2022-08-18 at 9.30.45 AM.png Screenshot 2022-08-18 at 9.32.56 AM.png Cc: @albinAppsmith, @tanvibhakta

shadabbuchh avatar Aug 18 '22 05:08 shadabbuchh

/ok-to-test sha=c1b3d45

albinAppsmith avatar Aug 18 '22 05:08 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2880219615. Workflow: Appsmith External Integration Test Workflow. Commit: c1b3d45. PR: 15562.

github-actions[bot] avatar Aug 18 '22 06:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2880219615. Commit: c1b3d45. Results:

Click to view performance test results

Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)

github-actions[bot] avatar Aug 18 '22 06:08 github-actions[bot]

/ok-to-test sha=506074c

albinAppsmith avatar Aug 19 '22 07:08 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2887958951. Workflow: Appsmith External Integration Test Workflow. Commit: 506074c. PR: 15562.

github-actions[bot] avatar Aug 19 '22 08:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2887958951. Commit: 506074c. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 418.16 410.98 409.7 431.78 513.15 418.16 436.75 23.69 9.98 8.93
painting 5.17 5.04 3.93 3.83 5.83 5.04 4.76 42.02 18.07 16.18
rendering 109.62 105.49 105.93 111.45 113.63 109.62 109.22 7.45 3.21 2.87
BIND_TABLE_DATA
scripting 1253.85 1220 1157.18 1248.97 1189.65 1220 1213.93 7.96 3.36 3.01
painting 12.56 11.58 14.21 14.53 16.42 14.21 13.86 34.92 13.49 12.05
rendering 821.76 774.6 787.49 820.42 830.98 820.42 807.05 6.99 3.04 2.72
CLICK_ON_TABLE_ROW
scripting 1054.75 1095.1 1095.23 1188.06 1409.8 1095.23 1168.59 30.38 12.27 10.98
painting 8.96 16.62 11.98 12.31 18.92 12.31 13.76 72.38 28.85 25.80
rendering 311.22 307.19 309.62 326.2 306.4 309.62 312.13 6.34 2.60 2.32
UPDATE_POST_TITLE
scripting 1638.24 1660.43 1702.91 1677.36 1580.32 1660.43 1651.85 7.42 2.81 2.52
painting 14.19 18.66 15.22 15.49 20.09 15.49 16.73 35.27 15.00 13.45
rendering 449.72 453.59 471.63 466.66 452.78 453.59 458.88 4.77 2.10 1.88
OPEN_MODAL
scripting 921.27 594.55 617.73 610.97 572.48 610.97 663.4 52.58 21.89 19.58
painting 10.63 13 16.28 17.25 25.28 16.28 16.49 88.84 33.84 30.26
rendering 369.59 383.48 376.81 385.79 389.78 383.48 381.09 5.30 2.09 1.87
CLOSE_MODAL
scripting 366.48 421.37 376.07 417.13 368.71 376.07 389.95 14.08 6.93 6.20
painting 4.82 5.1 8.05 10.79 14.06 8.05 8.56 107.94 45.79 41.00
rendering 626.31 642.92 629.18 667.53 643.08 642.92 641.8 6.42 2.54 2.27
SELECT_WIDGET_MENU_OPEN
scripting 1005.46 1016.43 1029.81 1037.37 1018.27 1018.27 1021.47 3.12 1.21 1.08
painting 4.51 10.96 13.8 9.89 7.21 9.89 9.27 100.22 38.40 34.30
rendering 600.26 607.4 598.99 599.46 612.94 600.26 603.81 2.31 1.02 0.91
SELECT_WIDGET_SELECT_OPTION
scripting 153.77 145 154.3 151.18 150.29 151.18 150.91 6.16 2.46 2.20
painting 7.69 6.35 5.52 4.21 2.32 5.52 5.22 102.87 39.46 35.25
rendering 299.7 306.41 302.96 304.33 302.03 302.96 303.09 2.21 0.83 0.74

github-actions[bot] avatar Aug 19 '22 08:08 github-actions[bot]

Retested the issues. Everything working as expected.

shadabbuchh avatar Aug 19 '22 10:08 shadabbuchh

/ok-to-test sha=fa53adb

albinAppsmith avatar Aug 19 '22 12:08 albinAppsmith

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2889323449. Workflow: Appsmith External Integration Test Workflow. Commit: fa53adb. PR: 15562.

github-actions[bot] avatar Aug 19 '22 12:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2889323449. Commit: fa53adb. Results:

Click to view performance test results

Run 1 (ms) Run 2 (ms) Run 3 (ms) Run 4 (ms) Run 5 (ms) Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)
SELECT_CATEGORY
scripting 293.24 300.44 292.6 284.39 286.49 292.6 291.43 5.51 2.17 1.94
painting 4.22 4.22 4.11 6.32 4.29 4.22 4.63 47.73 20.52 18.36
rendering 106.22 107.89 109.54 105.85 105.61 106.22 107.02 3.67 1.56 1.39
BIND_TABLE_DATA
scripting 1183.39 1173.58 1149.78 1145.51 1205.97 1173.58 1171.65 5.16 2.13 1.90
painting 15.66 7.05 14.97 14.7 17.39 14.97 13.95 74.12 28.67 25.66
rendering 770.09 790.89 771.61 765.37 803.54 771.61 780.3 4.89 2.08 1.86
CLICK_ON_TABLE_ROW
scripting 747.22 826.51 1095.89 847.11 844.96 844.96 872.34 39.97 15.07 13.48
painting 8.47 15.1 8.85 9.74 12.63 9.74 10.96 60.49 25.82 23.08
rendering 283.76 294.53 317.36 294.44 293.89 294.44 296.8 11.32 4.17 3.73
UPDATE_POST_TITLE
scripting 1410.26 1299.37 1289.34 1262.34 1295.02 1295.02 1311.27 11.28 4.36 3.90
painting 18.53 12.63 16.09 13.24 14.43 14.43 14.98 39.39 15.89 14.22
rendering 446.78 438.97 438.63 455 441.13 441.13 444.1 3.69 1.56 1.39
OPEN_MODAL
scripting 532.93 548.35 502.07 533.94 992.72 533.94 622 78.88 33.43 29.90
painting 12.2 18.86 13.25 11.42 9 12.2 12.95 76.14 28.26 25.25
rendering 377.75 397.22 368.43 380.84 381.27 380.84 381.1 7.55 2.73 2.44
CLOSE_MODAL
scripting 296.19 324.13 764.23 302.14 334.78 324.13 404.29 115.77 49.92 44.65
painting 10.04 4.78 3.96 6.82 5.7 5.7 6.26 97.12 37.86 33.87
rendering 593.34 648.4 617.04 603.61 617.38 617.04 615.95 8.94 3.37 3.01
SELECT_WIDGET_MENU_OPEN
scripting 1066.42 1219.42 1226.51 1133.88 1097.52 1133.88 1148.75 13.94 6.26 5.60
painting 5.98 10.27 11.11 12.93 10.45 10.45 10.15 68.47 25.22 22.56
rendering 616.58 675.8 767.33 677.81 644.35 675.8 676.37 22.29 8.39 7.50
SELECT_WIDGET_SELECT_OPTION
scripting 163.82 136.09 150.27 171.45 145.75 150.27 153.48 23.04 9.23 8.26
painting 3.67 4.46 2.37 7.83 4.83 4.46 4.63 117.93 43.63 39.09
rendering 312.34 318.18 340.16 412.15 370.87 340.16 350.74 28.46 11.78 10.53

github-actions[bot] avatar Aug 19 '22 13:08 github-actions[bot]