appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: Reskinning Input Widgets

Open jsartisan opened this issue 2 years ago • 3 comments

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

jsartisan avatar Jul 29 '22 11:07 jsartisan

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 3:41AM (UTC)

vercel[bot] avatar Jul 29 '22 11:07 vercel[bot]

Unable to find test scripts. Please add necessary tests to the PR.

github-actions[bot] avatar Jul 29 '22 11:07 github-actions[bot]

Tested this PR for enhancements of #11061 , #11023 , #11026

  • Input Widget Reskinning - Changes looks good and widget works fine without any breakage
  • Currency Input widget - Changes LGTM
  • Phone Input widget - Changes LGTM

chandannkumar avatar Aug 09 '22 12:08 chandannkumar

/ok-to-test sha=0bcb425

jsartisan avatar Aug 10 '22 09:08 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2831837389. Workflow: Appsmith External Integration Test Workflow. Commit: 0bcb425. PR: 15546.

github-actions[bot] avatar Aug 10 '22 10:08 github-actions[bot]

/ok-to-test sha=ecaea9b

Aishwarya-U-R avatar Aug 10 '22 16:08 Aishwarya-U-R

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2834264366. Workflow: Appsmith External Integration Test Workflow. Commit: ecaea9b. PR: 15546.

github-actions[bot] avatar Aug 10 '22 16:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2834264366. Commit: ecaea9b. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1075.19 1072.45 1107.79 1080.88 1055.46 1075.19 1078.35 1.76 1.57
painting 9.03 5.93 7 9.35 8.14 8.14 7.89 18.12 16.10
rendering 819.43 843.99 856.69 852.54 843.58 843.99 843.25 1.71 1.53
SELECT_WIDGET_SELECT_OPTION
scripting 151.78 164.49 162.47 216.87 172.21 164.49 173.56 14.57 13.03
painting 10.5 4.23 6.33 3.93 3.9 4.23 5.78 48.96 43.77
rendering 301.08 313.4 312.15 309.15 304.66 309.15 308.09 1.67 1.50

github-actions[bot] avatar Aug 10 '22 17:08 github-actions[bot]

/ok-to-test sha=68bd119

jsartisan avatar Aug 11 '22 05:08 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2837778946. Workflow: Appsmith External Integration Test Workflow. Commit: 68bd119. PR: 15546.

github-actions[bot] avatar Aug 11 '22 06:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2837778946. Commit: 68bd119. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1038.58 1091.53 1028.03 1061.93 1073.31 1061.93 1058.68 2.43 2.17
painting 5.58 12.3 12.22 5.21 12.6 12.22 9.58 39.98 35.70
rendering 830.31 849.62 824.01 829.57 828.57 829.57 832.42 1.19 1.07
SELECT_WIDGET_SELECT_OPTION
scripting 167.7 152.99 164.29 148.75 163.7 163.7 159.49 5.11 4.57
painting 2.26 4.15 4.48 3.86 3.1 3.86 3.57 24.93 22.41
rendering 311.73 306.18 305.31 313.41 306.79 306.79 308.68 1.18 1.05

github-actions[bot] avatar Aug 11 '22 07:08 github-actions[bot]

/ok-to-test sha=2b2f389

jsartisan avatar Aug 11 '22 15:08 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2841089691. Workflow: Appsmith External Integration Test Workflow. Commit: 2b2f389. PR: 15546.

github-actions[bot] avatar Aug 11 '22 15:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2841089691. Commit: 2b2f389. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1126.89 1136.04 1115.03 1140.28 1091.97 1126.89 1122.04 1.73 1.55
painting 8.67 10.42 9.41 17.43 9.36 9.41 11.06 32.73 29.20
rendering 880.18 888.26 882.41 869.5 828 880.18 869.67 2.79 2.50
SELECT_WIDGET_SELECT_OPTION
scripting 166.44 259.68 173.44 170.64 155.21 170.64 185.08 22.84 20.43
painting 9.16 8.3 2.78 4.63 4.97 4.97 5.97 44.72 40.03
rendering 316.93 316.45 320.91 315.51 306.33 316.45 315.23 1.71 1.53

github-actions[bot] avatar Aug 11 '22 16:08 github-actions[bot]

/ok-to-test sha=2b2f389

jsartisan avatar Aug 12 '22 10:08 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2845996002. Workflow: Appsmith External Integration Test Workflow. Commit: 2b2f389. PR: 15546.

github-actions[bot] avatar Aug 12 '22 10:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2845996002. Commit: 2b2f389. Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1089.64 1067.36 1071.44 1064.43 1058.05 1067.36 1070.18 1.11 1.00
painting 5.52 6.3 7.31 10.25 6.72 6.72 7.22 25.07 22.44
rendering 830.99 822.26 839.69 832.62 819.97 830.99 829.11 0.97 0.87
SELECT_WIDGET_SELECT_OPTION
scripting 145.01 158.64 147.38 168.52 170.38 158.64 157.99 7.39 6.61
painting 10.47 1.89 3.87 4.41 6.09 4.41 5.35 60.37 54.02
rendering 303.92 307.84 308.5 311.58 297.57 307.84 305.88 1.76 1.58

github-actions[bot] avatar Aug 12 '22 10:08 github-actions[bot]

/ok-to-test sha=c5523f8

jsartisan avatar Aug 16 '22 16:08 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2869560418. Workflow: Appsmith External Integration Test Workflow. Commit: c5523f8. PR: 15546.

github-actions[bot] avatar Aug 16 '22 16:08 github-actions[bot]

/ok-to-test sha=95ff6c2

jsartisan avatar Aug 17 '22 09:08 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2874307921. Workflow: Appsmith External Integration Test Workflow. Commit: 95ff6c2. PR: 15546.

github-actions[bot] avatar Aug 17 '22 10:08 github-actions[bot]

/ok-to-test sha=14fe359

jsartisan avatar Aug 18 '22 03:08 jsartisan

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2879772397. Workflow: Appsmith External Integration Test Workflow. Commit: 14fe359. PR: 15546.

github-actions[bot] avatar Aug 18 '22 03:08 github-actions[bot]

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2879772397. Commit: 14fe359. Results:

Click to view performance test results

Median (ms) Mean (ms) Range (%) SD.Sample (%) SD.Population (%)

github-actions[bot] avatar Aug 18 '22 04:08 github-actions[bot]