appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Bug]: Table Widget V2 UpdatedRow Is Always An Empty Object

Open megaconfidence opened this issue 1 year ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

The Table1.updatedRow object never gets updated with the edited information when a row is submitted, saved or discarded. The video below for more details

https://user-images.githubusercontent.com/17744578/181265143-90950c30-bccd-467d-8582-82ae2b271dd6.mp4

Steps To Reproduce

See the video below

https://user-images.githubusercontent.com/17744578/181265143-90950c30-bccd-467d-8582-82ae2b271dd6.mp4

Public Sample App

No response

Version

Cloud/Appsmith v1.7.9-SNAPSHOT

megaconfidence avatar Jul 27 '22 13:07 megaconfidence

@dilippitchika @sbalaji1192 this seems like a very basic bug. How is inline editing working?

Nikhil-Nandagopal avatar Aug 09 '22 06:08 Nikhil-Nandagopal

@Nikhil-Nandagopal so we simply reused triggeredRow as updatedRow, it works once you bind something to onclick. We kept this bug open to fix the issue of it not showing up by default

dilippitchika avatar Aug 09 '22 13:08 dilippitchika

@dilippitchika ok but that seems like a bug, because if we suddenly realise that the triggered row should have the original values and not the edited values, we won't be able to migrate users who used this method. Can we fix this?

Nikhil-Nandagopal avatar Aug 10 '22 06:08 Nikhil-Nandagopal

Yeah we are fixing this, that's exactly why we kept this issue open

dilippitchika avatar Aug 10 '22 07:08 dilippitchika

Fix -

  1. updatedRow should be available as soon as a user updates a table cell. Not edits, but updates.
  2. updatedRow when the mode is set to custom should show data of the most recent row which is updated.

dilippitchika avatar Aug 15 '22 05:08 dilippitchika

Thanks for working on this @keyurparalkar 🙏

megaconfidence avatar Jan 05 '23 12:01 megaconfidence