appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Feat]:There is no option to push committed changes after git push fails

Open vishnu-gp opened this issue 3 years ago • 2 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

When for some reason git push fails, Appsmith commits the changes but there is no option to push those commits and deploy the app in the next try unless the user makes another change in the app then commit and push.

Screenshot 2022-07-15 at 12 44 32

The expected behaviour should be either adding a push feature for already committed changes or discarding the commits that happened while a push fails after the failure.

https://www.loom.com/share/9b3f7d3f4cc3421da0fb8985ea825832

Steps To Reproduce

  1. Create an application and connect it to git
  2. Mark the branch as protected on GitHub
  3. Make some changes in the app and try to push
  4. After the push fails close and reopen the modal https://www.loom.com/share/9b3f7d3f4cc3421da0fb8985ea825832

Public Sample App

No response

Version

1.7.8

vishnu-gp avatar Jul 21 '22 06:07 vishnu-gp

Stats

Stat Values
Reach 90
Effort (months) 0.25

Estimating that 10% of the Git users making a commit will run into a push failure here: 90

vuiets avatar Jul 22 '22 06:07 vuiets

Can we effectively handle this error in UI? To some extent, this problem can be resolved by providing a proper error message to the user. @brayn003 @infinitetrooper

ginilpg avatar Jun 21 '23 09:06 ginilpg

Handled with native git connection

RoopKrrish9696 avatar Aug 09 '24 07:08 RoopKrrish9696