appsmith
appsmith copied to clipboard
appsmithorg
[Bug]: More menu items exceed the canvas
Is there an existing issue for this?
- [X] I have searched the existing issues
Current Behavior
In menu button widget when new Menu items are added in property pane the bottom border is not visible after the 5th new menu item
When more number of menu items are added the items move out of canvas
https://loom.com/share/3398a3caca3a4b0d95cc4b07d0f846c3
Steps To Reproduce
- Drag and drop Menu button widget
- In property pane add new buttons
Environment
Production
Version
Cloud
@tauantcamargo Thanks for showing interest. I'm assigning this issue to you. I would appreciate it if you could create a PR within two days. All the best!
@Naveen-Nair & @beheradibas As this is assigned, Please pick a different issue from our issues page. If this is your first time contributing to the repo, You can start with a Good first issue.
@sbalaji1192 assign it to @beheradibas no worries .. i can do it today :/
Greetings @Naveen-Nair thanks for showing interest 🎉 , This is all your. Assigning this to you now.
Please don't forget to read the Contribution Guidelines. Would appreciate if you can open a PR within the next 2 days. let us know here
Hey sorry, i'm a bit busy this weekend, so i don't think i'd be able to work on it
Hi @dilippitchika, I have reproduced this issue and would like to work on this. Thanks.
I am little confused as I tried adding menu buttons but they perfectly working. Can anyone clear me out?
Hi @trishitapingolia this issue is fixed now. Looks like the only issue pending is a missing scroll on the menu items inside the widget (image 2 in the issue description)
Greetings @secure-crypto thanks for showing interest 🎉 , This is all yours. Assigning this to you now.
Please don't forget to read the Contribution Guidelines. Would appreciate if you can open a PR within the next 2 days. let us know here
Hi @dilippitchika I investigated this and seems to me there will be a change in this file - https://github.com/appsmithorg/appsmith/blob/release/app/client/src/widgets/MenuButtonWidget/component/index.tsx. I am quite new to React so trying to understand what changes to make. Will update here on my progress.
Thanks for checking @secure-crypto, @yaldram can you please help here on where the change needs to be?
@secure-crypto On line 228 we can try giving a fixed height like height: 380px and overflow-y: scroll.
@secure-crypto For this class .menu-button-popover, .bp3-minimal.menu-button-popover.bp3-popover2 disable overflow-y property on line 44, I think.
@somangshu @dilippitchika is this issue is fixed ? If not than please assign me I would like to work on this issue.
Greetings @MuhammadAakash, thanks for showing interest 🎉 , This is all your. Assigning this to you now.
Please don't forget to read the Contribution Guidelines. Would appreciate if you can open a PR within the next 2 days and request for the review here
Apologies for the late response here
@somangshu I will start working on this issue in weekend, so maybe it will take more than 2 days.
@somangshu Sorry for late, but Previously I was getting some errors during the setup, but now completed and I am working on it.
@somangshu I have created the PR https://github.com/appsmithorg/appsmith/pull/20579. Please review it