appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Enhancement] : Currency input widget reskinning

Open dilippitchika opened this issue 3 years ago • 7 comments

Scope - https://www.notion.so/appsmith/Currency-widget-03bf484b3e474058aad34d6da4a0dac3

dilippitchika avatar Feb 09 '22 06:02 dilippitchika

We have found issues that are potential duplicates:

  • [#11023] [Enhancement] : Phone input widget reskinning (87.18%) If any of the issues listed above are a duplicate, please consider closing this issue & upvoting the original one.
    Alternatively, if neither of the listed issues addresses your feature/bug, keep this issue open.

github-actions[bot] avatar Feb 09 '22 06:02 github-actions[bot]

Currency widget missing items:

  1. No currency found state missing
  2. Is the width of the currency search popup fixed?
  3. What happens when the length of a currency with country extends the width. How does the wrapping work?
  4. Designs do not show scroll bar in the dropdown, please add scroll

dilippitchika avatar Feb 10 '22 13:02 dilippitchika

Observations:

  1. Search icon is overlapped with 'x' icon on the search bar of dropdown. Also the 'x' is unclickable image.png

  2. When we add Currency widget somewhere at the bottom of the canvas, Clicking to open dropdown it jumps to the top area of the canvas on edit and preview mode https://www.loom.com/share/c8c3f4bdc7eb4472b6913de177bcf3f9

  3. There is a slight cut of the Label when 'Label Font Style' is selected as Italic (Issue is present on prod as well) image.png

  4. Arrow icon doesn't look same as mentioned on Design image.png

  5. There is no change in Error state border. The new design looks different than production image.png

Note: The issue reported above are also similar in Phone Input widget as well @jsartisan

chandannkumar avatar Aug 04 '22 09:08 chandannkumar

@laveena-en @vivekverma2312 since chandon is OOO, can someone else pick this up?

jsartisan avatar Aug 08 '22 04:08 jsartisan

@jsartisan I am available and I will continue testing this

chandannkumar avatar Aug 08 '22 05:08 chandannkumar

On the above callouts point 2 will get fixed later

chandannkumar avatar Aug 09 '22 12:08 chandannkumar

LGTM Moving this to Done

chandannkumar avatar Aug 09 '22 12:08 chandannkumar