appsignal-ruby icon indicating copy to clipboard operation
appsignal-ruby copied to clipboard

Sinatra applications wrapped in many middleware loses Sinatra config

Open tombruijn opened this issue 9 years ago • 5 comments

See PR #156 and comment https://github.com/appsignal/appsignal-ruby/pull/156#issuecomment-247567473

tombruijn avatar Sep 16 '16 12:09 tombruijn

@tombruijn can you give your opinion on wether we should fix this issue or ignore because it's a rare occurrence?

wesoudshoorn avatar Dec 05 '16 10:12 wesoudshoorn

Well it's really @jeffkreeftmeijer's issue ;)

But yes I think it's an important issue and could be quite common. Sinatra apps with multiple middlewares where AppSignal is not loaded first lose part of their config. So we're changing the behavior of Sinatra apps without the user knowing. That's something we should never do. Previously this raised an error, now we're hiding it, but it should still be fixed.

tombruijn avatar Dec 05 '16 15:12 tombruijn

Is this related to #149?

thijsc avatar Feb 20 '17 12:02 thijsc

No it's a different issue unfortunately

tombruijn avatar Feb 21 '17 10:02 tombruijn

We might be able to review/fix this in #329

tombruijn avatar Aug 11 '17 08:08 tombruijn