appsignal-nodejs icon indicating copy to clipboard operation
appsignal-nodejs copied to clipboard

Fastify instrumentation may not report errors?

Open unflxw opened this issue 1 year ago • 3 comments

We saw an issue during a call where a customer (Intercom link) did not see errors reported from their Fastify application's error handlers automatically. (This customer was affected by #974, but the issue persisted after the workaround was applied)

Another workaround was used, in which a custom Fastify error handler was used to manually forward errors to AppSignal.

To do

  • [ ] Attempt to reproduce in our test setup?
  • If reproduced:
    • [ ] Document custom error handler
    • [ ] Report to upstream OpenTelemetry instrumentation

unflxw avatar Jan 18 '24 20:01 unflxw

:heavy_check_mark: All good!

New issue guide | Backlog management | Rules | Feedback

backlog-helper[bot] avatar Jan 18 '24 20:01 backlog-helper[bot]

Would you be able to provide the solution for the custom fastify error handler? I'm experience the same issue and would like to try the given solution.

brogeby avatar Mar 06 '24 23:03 brogeby

  • This issue has not had any activity in 14 days. Please provide a status update if it is still relevant. Closed it if it is no longer relevant. Or move it to another column if it's blocked or requires another look at it. - (More info)

This is a message from the daily scheduled checks.

New issue guide | Backlog management | Rules | Feedback

backlog-helper[bot] avatar Aug 02 '24 08:08 backlog-helper[bot]

This is fixed in newer versions of @appsignal/nodejs (^3.4.8).

luismiramirez avatar Aug 12 '24 09:08 luismiramirez