appsignal-nodejs icon indicating copy to clipboard operation
appsignal-nodejs copied to clipboard

Add Pino support to the logger

Open unflxw opened this issue 2 years ago • 10 comments

Like Winston (see #821) Pino also supports transports, so we can probably tie it into the logging API in a similar way.

In the Intercom thread from #821., the customer mentioned Pino would also be interesting to have.

To do

unflxw avatar Jan 09 '23 10:01 unflxw

:heavy_check_mark: All good!

New issue guide | Backlog management | Rules | Feedback

backlog-helper[bot] avatar Jan 09 '23 10:01 backlog-helper[bot]

@unflxw can you add a section with a To do list that describes in detail the steps someone has to take to complete this issue?

tombruijn avatar Jan 09 '23 10:01 tombruijn

This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.

If a blog post is not required, please add the [skip blogpost] tag next time, and close the created issue.

backlog-helper[bot] avatar Feb 20 '23 11:02 backlog-helper[bot]

This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.

If a blog post is not required, please add the [skip blogpost] tag next time, and close the created issue.

backlog-helper[bot] avatar Feb 20 '23 11:02 backlog-helper[bot]

Moving this to backlog until we're able to log via HTTP.

Pino transports are run as worker threads. We can't pass the client safely as an argument to the worker initialization, and as we're using TS, making users write a built file path is not an ideal solution.

luismiramirez avatar Feb 28 '23 08:02 luismiramirez

Would also be interesting for my company, we just started using Appsignal and we'd love to move our logging to Appsignal.

pantajoe avatar Apr 11 '23 13:04 pantajoe

Thanks @pantajoe! We may take another look at this issue soon. In the meantime, note that we do support Winston.

unflxw avatar Apr 11 '23 14:04 unflxw

https://app.intercom.com/a/inbox/yzor8gyw/inbox/admin/4356044/conversation/16410700256468?view=List (private link)

shairyar avatar Oct 10 '23 08:10 shairyar

Is this still being considered? Since the start of this thread, Pino has grown closer to Winston in terms of adoption and is still faster than Winston, which is why we prefer it in our stack.

pino,winston

I found this transporter in user land https://github.com/duailibe/pino-appsignal-transport, but official support would still be awesome! :)

mgm1313 avatar Sep 21 '24 09:09 mgm1313

@mgm1313 hey, thank you!

Yes, we're considering this and we're moving it ahead soon.

luismiramirez avatar Sep 26 '24 09:09 luismiramirez