appsignal-nodejs
appsignal-nodejs copied to clipboard
Add Pino support to the logger
Like Winston (see #821) Pino also supports transports, so we can probably tie it into the logging API in a similar way.
In the Intercom thread from #821., the customer mentioned Pino would also be interesting to have.
To do
- [ ] Implement Pino transport (see our Winston transport documentation and Pino's transport documentation for reference)
- [ ] Document it next to the Winston transport documentation
- [ ] Notify user who requested it.
- [ ] Request the addition to Pino known transports list
@unflxw can you add a section with a To do list that describes in detail the steps someone has to take to complete this issue?
This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.
If a blog post is not required, please add the [skip blogpost]
tag next time, and close the created issue.
This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.
If a blog post is not required, please add the [skip blogpost]
tag next time, and close the created issue.
Moving this to backlog until we're able to log via HTTP.
Pino transports are run as worker threads. We can't pass the client safely as an argument to the worker initialization, and as we're using TS, making users write a built file path is not an ideal solution.
Would also be interesting for my company, we just started using Appsignal and we'd love to move our logging to Appsignal.
Thanks @pantajoe! We may take another look at this issue soon. In the meantime, note that we do support Winston.
https://app.intercom.com/a/inbox/yzor8gyw/inbox/admin/4356044/conversation/16410700256468?view=List (private link)
Is this still being considered? Since the start of this thread, Pino has grown closer to Winston in terms of adoption and is still faster than Winston, which is why we prefer it in our stack.
I found this transporter in user land https://github.com/duailibe/pino-appsignal-transport, but official support would still be awesome! :)
@mgm1313 hey, thank you!
Yes, we're considering this and we're moving it ahead soon.