appsignal-nodejs icon indicating copy to clipboard operation
appsignal-nodejs copied to clipboard

Remove the need for an Express error handler

Open luismiramirez opened this issue 10 months ago • 1 comments

The OpenTelemetry Express instrumentation now automatically records exceptions without the need of an error handler.

See: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1657

ToDo

  • [ ] Update the integration dependency
  • [ ] Update test-setups
  • [ ] Update the docs

luismiramirez avatar Apr 25 '24 08:04 luismiramirez

Going by the linked PR, it seems that it only records exceptions in middlewares? Does that cover our needs?

unflxw avatar May 08 '24 14:05 unflxw

That change doesn't cover our needs.

Here's an open issue reporting problems with the change: https://github.com/open-telemetry/opentelemetry-js-contrib/issues/2146

Internal link with the conversation: https://appsignal.slack.com/archives/C06TU59PXDF/p1714031628760559

luismiramirez avatar Aug 26 '24 09:08 luismiramirez