ApprovalTests.Java icon indicating copy to clipboard operation
ApprovalTests.Java copied to clipboard

DateScrubber.getScrubberFor doesn't support the following

Open LarsEckart opened this issue 5 years ago • 11 comments

if your particular date is not supported, please add it here.

Legend

👀 = we've seen it, we deal with it next time we come together 🚀 = Date format has been added

LarsEckart avatar Sep 23 '20 05:09 LarsEckart

default date format Wed Sep 22 22:49:42 PDT 2021

AWinterman avatar Sep 24 '21 05:09 AWinterman

default date format Wed Sep 22 22:49:42 PDT 2021

https://github.com/approvals/ApprovalTests.Java/releases/tag/12.3.1 :)

LarsEckart avatar Nov 19 '21 07:11 LarsEckart

that's interesting, in the past (jdk 17?) a call to new Date() returned Wed Nov 17 22:28:33 EET 2021, now the test fails because currently this call returns Tue Apr 05 18:32:30 EEST 2022. EET -> EEST

LarsEckart avatar Apr 05 '22 15:04 LarsEckart

Format of the HTTP Date Header Wed, 21 Oct 2015 07:28:00 GMT matches (Mon|Tue|Wed|Thu|Fri|Sat|Sun), \d{2} (Jan|Feb|Mar|Apr|May|Jun|Jul|Aug|Sep|Oct|Nov|Dec) \d{4} \d{2}:\d{2}:\d{2} GMT

ssiegler avatar Sep 29 '22 13:09 ssiegler

@ssiegler added in https://github.com/approvals/ApprovalTests.Java/commit/3f2c230f66ee4a83e5af36ebaab0503ba09ed76c it'll go live with the next release (probably next Monday).

LarsEckart avatar Oct 06 '22 06:10 LarsEckart

2023-05-18T09:25:10.127 / 2023-05-18T09:25:11.71 \d{4}-\d{1,2}-\d{1,2}T\d{1,2}:\d{2}:\d{2}.\d{1,3}

prerakatolia avatar May 18 '23 09:05 prerakatolia