lucid icon indicating copy to clipboard operation
lucid copied to clipboard

Published 20 hours ago • verified publisher icon appnexus

Basic Button Icon + Text has uncentered padding

Open rsadres opened this issue 6 years ago • 3 comments

Buttons have standard padding, Icons have standard padding, it's looking like when we bundle all of that together, the icon + text buttons are lopsided, they have more space on the left side than on the right side. Is there something we can do to make the icon + text buttons even, without affecting the other buttons or other places where the checkIcon is used? screenshot 2018-08-07 09 57 14

I feel like this came up before and we resolved it before...

rsadres avatar Aug 07 '18 17:08 rsadres

@liliedelamotte , let's look at Joe's selector fix - https://codepen.io/jhsu/pen/PBgqqe?editors=0010

rsadres avatar Aug 14 '18 16:08 rsadres

Per @jondlm suggestion, let's create a new icon/text button component.

These icons are frequently used in icon/text buttons. Let's make sure we optimize styling to accommodate these. PlusIcon EditPageIcon EditIcon ViewIcon DownloadIcon DuplicateIcon UploadIcon

We occasionally use these icons in icon/text buttons, can we see if any of these break just to be aware. ArrowIcon DeleteIcon SwitchIcon UserIcon

rsadres avatar Aug 15 '18 20:08 rsadres

Not necessarily related, but these icons are frequently used in in Icon only buttons, maybe we should check on these while we're here :)

TableGearIcon RefreshIcon EditIcon AnalyzeDataIcon DataViewIcon EditPageIcon DeleteIcon DuplicateIcon SettingsIcon

rsadres avatar Aug 15 '18 20:08 rsadres