djangular
djangular copied to clipboard
djangular's karma support should be updated, and can be enhanced
Djangular supports developers writing karma using these two management commands:
-
makeangularsite
creates karma config file templates that handle the djangular app paths -
testjs
will shell out tokarma
and run the appropriate config file
the first is in need of an update: as karma is on 0.12 and djangular writes out a file that's no longer compatible (I believe we're writing out a 0.8-style file, but there was backwards incompatible change in 0.9 or 0.10)
the second could use some enhancements:
- the management command assumes that
karma
exists on the path (which isn't typical when not installing usingnpm -g
) - there's no way to pass additional command line arguments to the
karma
invocation, which is useful for having jenkins run against PhantomJS and then letting developers override this at their desktops to run Firefox/Chrome - running
testjs
assume's that you have a very particular working directory so it can find an app's config files. It would be convenient lettestjs
work no matter your working directory.
+1