darkstar
darkstar copied to clipboard
applied-science
Upgrading vega-lite version
Both Vega and Vega lite have had significant version releases this past year.
In order to upgrade, I should ideally be able to fork your repo, stick in the new .js files and get them to work. However, I see you've patched a polyfill on vega.js(though not on vega lite, understandably). So what upgrade path would you recommend?
These patches are needed because some parts of Vega are hardcoded to work differently between Node and the browser, but Darkstar is neither of those and needs some functionality from each (network and filesystem resource fetching). If you want to have a good at doing the upgrade yourself, the best way would be to diff the original vega.js against my patched version and then try to introduce the same modifications to the new version.
I've done this and it seems to be working. But it will require some more testing, though, honestly there shouldn't be much more to it. Will keep you updated.
@jackrusher - The tests have a dependency on javax.xml.bind.DatatypeConverter which seems to have been one of the packages removed from the JDK after Java 9. Are you running them on an older version or are you adding the modules on the classpath at runtime? If so, shouldn't that be in deps.edn ?
Sorry, busy few days. I must have been testing with an older JVM. Why not add it to the test section of the deps.edn and give it a go on a newer JVM?