estuary icon indicating copy to clipboard operation
estuary copied to clipboard

fix the pinning api filtering

Open ohmpatel1997 opened this issue 2 years ago • 3 comments

  • This PR fixes the status based filtering on the list pins api.

ohmpatel1997 avatar Jul 14 '23 10:07 ohmpatel1997

I'm wondering if we shouldn't add either a new endpoint or new query param for this. We want to make sure we don't break any backward compatibility. @alvin-reyes what do you think?

LucRoy avatar Jul 19 '23 16:07 LucRoy

make sure we don't break any backw

I think the previous logic was flawed in itself. So even if someone was using it must be giving them the wrong results. also it wont break any existing api's schema, since we are not chaning any query param types.

ohmpatel1997 avatar Jul 20 '23 12:07 ohmpatel1997