estuary icon indicating copy to clipboard operation
estuary copied to clipboard
verified publisher icon application-research

Clarify difference between --no-storage-cron and --disable-deal-making

Open gmelodie opened this issue 3 years ago • 1 comments

--no-storage-cron starts the worker that initiates new deals or reconcile old deals. If turned on no new deals and the state of existing deals will not be updated/checked.

--disable-deal-making: prevents making new deals but reconciliation still happens for existing deals

We need to make the differences more obvious on the --help strings as well as the namings of these.

Relevant slack discussion: https://filecoinproject.slack.com/archives/C016APFREQK/p1658934465974939

gmelodie avatar Jul 27 '22 15:07 gmelodie

Hi @gmelodie!

I'd like to start contributing to filecoin and estuary, can I grab this one? :)

fbac avatar Aug 11 '22 22:08 fbac

@fbac there's already a PR in for that (https://github.com/application-research/estuary/pull/388), but you're more than welcome to review that or take another issue :)

gmelodie avatar Aug 15 '22 10:08 gmelodie

@gmelodie this issue is closed? (I'm looking for another issue to do, this one looks like a good one)

mvjq avatar Sep 06 '22 19:09 mvjq

Yup closed on #388

gmelodie avatar Sep 08 '22 13:09 gmelodie