appleseed icon indicating copy to clipboard operation
appleseed copied to clipboard

Improvements to MacOS packaging

Open markreidvfx opened this issue 4 years ago • 10 comments

  • ported over changes from appleseed-maya packaging
  • package script optionally builds a Application
  • package script builds dmg file instead of zip

markreidvfx avatar Nov 10 '19 04:11 markreidvfx

@dictoon how is this for the drive icon instead? I rendered it with appleseed.

image

markreidvfx avatar Nov 17 '19 07:11 markreidvfx

I rendered it with appleseed.

Ah, lovely touch :)

The logo is a bit washed out, maybe that can be fixed in post to approach the correct color?

dictoon avatar Nov 17 '19 17:11 dictoon

The logo is a bit washed out

You are correct the texture is getting double srgb'd. Enabling CMS on the asTexure fixes it.

drive_icon_V2 0001

also keymixed in the albedo for the logo

markreidvfx avatar Nov 18 '19 00:11 markreidvfx

Lovely!

dictoon avatar Nov 18 '19 13:11 dictoon

Testing your script, I got the following error:

  Mac-specific: Adding dependencies to staging directory...
Traceback (most recent call last):
  File "./appleseed.package.py", line 1244, in <module>
    main()
  File "./appleseed.package.py", line 1238, in main
    package_builder.build_package()
  File "./appleseed.package.py", line 393, in build_package
    self.orchestrate()
  File "./appleseed.package.py", line 411, in orchestrate
    self.postprocess_stage()
  File "./appleseed.package.py", line 707, in postprocess_stage
    self.__add_dependencies_to_stage()
  File "./appleseed.package.py", line 734, in __add_dependencies_to_stage
    self.add_unix_dependencies_to_stage(self.get_paths_to_binaries())
  File "./appleseed.package.py", line 504, in add_unix_dependencies_to_stage
    libs = self.get_dependencies_for_file(path)
  File "./appleseed.package.py", line 993, in get_dependencies_for_file
    fatal("Unable to Resolve lib {}", lib)
TypeError: fatal() takes exactly 1 argument (2 given)

dictoon avatar Nov 19 '19 09:11 dictoon

Guess there needs to be a .format(lib) there instead

markreidvfx avatar Nov 26 '19 06:11 markreidvfx

Hi Mark,

I'd love to get this PR merged. Would you mind updating it? I'll also do some more tests in the coming days.

Thanks!

dictoon avatar Dec 21 '19 14:12 dictoon

Sorry for the delay, a couple other projects came up. I'll try and get this finished up when I'm back from holidays in the new year!

markreidvfx avatar Dec 21 '19 22:12 markreidvfx

Hi @markreidvfx, thanks your contribution :) Do you still plan on working on that PR? It seems there is very few changes to make before being able to merge it into master.

oktomus avatar Apr 10 '21 19:04 oktomus

Sorry, I got really busy and must have forgotten about this. I'll try and find some time to finish it, just have too many ongoing projects at the moment. If anyone want to take it over, feel free too.

markreidvfx avatar Apr 11 '21 06:04 markreidvfx