modal-video
modal-video copied to clipboard
change for compatibility with IE10
Hi. Thanks for this lib. it's working very well. However, i suggest one change for make it working on IE10
Change the use of "dataset" by getting directly the attribute
var videoId = selector.dataset.videoId; var channel = selector.dataset.channel || opt.channel; var id = (0, _util.getUniqId)(); var videoUrl = selector.dataset.videoUrl || _this.getVideoUrl(opt, channel, videoId);
become
var videoId = selector.getAttribute('data-video-id'); var channel = selector.getAttribute('data-channel') || opt.channel ; var id = (0, _util.getUniqId)(); var videoUrl = selector.getAttribute('data-video-url') || _this.getVideoUrl(opt, channel, videoId);
Thank you
Hello Colir, thanks for you fix as I had to support IE10 for this project :)