modal-video icon indicating copy to clipboard operation
modal-video copied to clipboard

Published 20 hours ago • verified publisher icon appleple

Wistia Support

Open cyberwani opened this issue 6 years ago • 4 comments

Added support for Wistia video.

cyberwani avatar May 14 '18 09:05 cyberwani

I needed wistia support, so i added it and finished about 5 hours ago, and you did the pull request after i finished...

RebliNk17 avatar May 14 '18 13:05 RebliNk17

Hi @cyberwani Thank you for adding the new video channel but why do you have to add 'modal-video-opened' class to the body element? I want you to remove that part.

steelydylan avatar May 14 '18 14:05 steelydylan

@cyberwani I think it is better to not use embedded api with wistia. The way you did it, the user has no control on the video. the Wistia API is not working. Maybe changing it to something like this is better https://gist.github.com/RebliNk17/0b17822060157e17a32890a9225392a2

Just need to add a call to run "initVideo"

RebliNk17 avatar May 15 '18 08:05 RebliNk17

Hi @steelydylan I added 'modal-video-opened' class to handle some specific formatting in my one project when video popup is open, and I think it can be useful to the user. But, it's not necessary and can be removed.

@RebliNk17 I had already had a script in another project, and I was running on tight schedule, so I did integration like this. It can be changed to something better with flexible support.

cyberwani avatar Jun 04 '18 12:06 cyberwani