gorush icon indicating copy to clipboard operation
gorush copied to clipboard

fix #538: use 1 logger

Open slimus opened this issue 4 years ago • 3 comments

We used 2 different systems for logging.

Now I removed old log system and use one logger everywhere

slimus avatar Oct 25 '21 17:10 slimus

Codecov Report

Merging #637 (01526be) into master (9d47494) will decrease coverage by 1.01%. The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   65.05%   64.04%   -1.02%     
==========================================
  Files          21       21              
  Lines        1783     1808      +25     
==========================================
- Hits         1160     1158       -2     
- Misses        562      591      +29     
+ Partials       61       59       -2     
Impacted Files Coverage Δ
logx/log.go 37.73% <0.00%> (-11.05%) :arrow_down:
router/server.go 77.32% <100.00%> (+3.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d47494...01526be. Read the comment docs.

codecov-commenter avatar Oct 25 '21 18:10 codecov-commenter

@slimus Thanks for your effort. Maybe I can improve the gin/logger package not copy the source code from gin/logger.

appleboy avatar Oct 26 '21 02:10 appleboy

It would be great :)

slimus avatar Oct 26 '21 02:10 slimus