gorush icon indicating copy to clipboard operation
gorush copied to clipboard

support sending to multiple different certs

Open gardenia opened this issue 6 years ago • 5 comments

Hi,

At the moment it appears I can configure exactly one Android API key and one IOS push certificate.

I would like the capability to somehow disptach to different Android API keys and IOS push certificates, perhaps based on an app bundle id. I realize I could run N instances of gorush to accomplish that but it seems more ideal to be be able to do it all from the same process.

What do you think?

e.g.

android:
  com.foo.bar:
    enabled: true
    apikey: "YOUR_API_KEY1"
    max_retry: 0 # resend fail notification, default value zero is disabled
  com.blah.blah:
    enabled: true
    apikey: "YOUR_API_KEY2"
    max_retry: 0 # resend fail notification, default value zero is disabled

gardenia avatar Aug 22 '18 12:08 gardenia

Gorush doesn't support multiple certificates in iOS but support send notification in the different android key.

In android, you can add api_key in the request body. See https://github.com/appleboy/gorush#request-body

appleboy avatar Aug 22 '18 13:08 appleboy

@appleboy @gardenia APNS is using Universal Push Notification Client SSL, so just one cert is ok. This issue can be closed.

wahello avatar May 01 '19 15:05 wahello

@keyeMyria Thanks

appleboy avatar May 01 '19 17:05 appleboy

I don't believe this is related to my original question. I wanted the ability to use a single gorunsh instance to send pushes to:

some.bundle.id -> cert1.pem other.bundle.id -> cert2.pem

by dispatching to the different certs on the bundle id. I don't see what "Universal Push Notification Client SSL" has to do with this as it appears to related to production vs development pushes for the same bundle id using one cert.

It may be that gorush never plans to support this. and if so fair enough. I just don't see how Universal Push Notification Client SSL solves it.

gardenia avatar May 01 '19 17:05 gardenia

might be addressed via #564

marius-bardan avatar Mar 25 '21 15:03 marius-bardan