drone-on-kubernetes icon indicating copy to clipboard operation
drone-on-kubernetes copied to clipboard

A few suggestions for the guide

Open wlan0 opened this issue 7 years ago • 4 comments

So, In order to get my drone setup working, I followed this guide. It's really well done, but there are few issues.

  • Kubernetes has support for dynamically provisioned volumes - this would improve the UX of this guide even further
  • By default, the service gets setup as a TCP forwarding service on ELB. The protocol on the port of the service is left as default (TCP) - It would be better to make it HTTP/HTTPS
  • It's not obvious that it needs to be HTTP, because if you set it to TCP, it works without SSL, but if you need HTTPS, then you need to explicitly specify the HTTPS in your setup - otherwise ELB won't add headers like X-Forward-Proto which is required for the authentication (oauth /authorize call requires the URLs to match, and url-scheme is defaulted to HTTP unless the X-Forward-Proto header is set) to succeed.

I can make a PR with information about how to do the above suggestions - If you'd like

wlan0 avatar Dec 18 '17 04:12 wlan0

I updated the title, cos I want to be fair - the guide works as it is, and is really well done :) :+1:

wlan0 avatar Dec 18 '17 04:12 wlan0

@wlan0 PR Welcome 👍

appleboy avatar Jan 07 '18 14:01 appleboy

Related to the load balancer, does the http/https load balancer work with serversent events?

Older drone versions required websockets which doesn't work with this load balancer. I don't know how it is with serversent events.

tboerger avatar Jan 23 '18 10:01 tboerger

@tboerger I read up on server-sent, my knowledge on this is limited.

It should work with HTTP/HTTPS load balancing. It doesn't seem to require any specialized headers.

FYI, this is the spec I read (https://www.w3.org/TR/eventsource/)

wlan0 avatar Jan 23 '18 18:01 wlan0