drone-on-kubernetes
drone-on-kubernetes copied to clipboard
A few suggestions for the guide
So, In order to get my drone setup working, I followed this guide. It's really well done, but there are few issues.
- Kubernetes has support for dynamically provisioned volumes - this would improve the UX of this guide even further
- By default, the service gets setup as a TCP forwarding service on ELB. The protocol on the port of the service is left as default (TCP) - It would be better to make it HTTP/HTTPS
- It's not obvious that it needs to be HTTP, because if you set it to TCP, it works without SSL, but if you need HTTPS, then you need to explicitly specify the HTTPS in your setup - otherwise ELB won't add headers like
X-Forward-Proto
which is required for the authentication (oauth/authorize
call requires the URLs to match, and url-scheme is defaulted toHTTP
unless theX-Forward-Proto
header is set) to succeed.
I can make a PR with information about how to do the above suggestions - If you'd like
I updated the title, cos I want to be fair - the guide works as it is, and is really well done :) :+1:
@wlan0 PR Welcome 👍
Related to the load balancer, does the http/https load balancer work with serversent events?
Older drone versions required websockets which doesn't work with this load balancer. I don't know how it is with serversent events.
@tboerger I read up on server-sent, my knowledge on this is limited.
It should work with HTTP/HTTPS load balancing. It doesn't seem to require any specialized headers.
FYI, this is the spec I read (https://www.w3.org/TR/eventsource/)