swift-system icon indicating copy to clipboard operation
swift-system copied to clipboard

Release Testing for 1.4.0

Open glessard opened this issue 2 years ago • 2 comments

  • [ ] Swift 5.6.3 on macOS

  • [ ] Swift 5.7.3 on macOS

  • [ ] Swift 5.8.1 on macOS

  • [x] Swift 5.9 on macOS

  • [ ] Swift 5.6.3 on Ubuntu 20.04 (x64)

  • [ ] Swift 5.7.3 on Ubuntu 22.04 (x64)

  • [ ] Swift 5.8.1 on Ubuntu 22.04 (x64)

  • [x] Swift 5.9 on Ubuntu 22.04

  • [ ] Swift 5.8.1 on Windows

glessard avatar Aug 17 '23 16:08 glessard

Time for a new tag? I'm seeing two test failures with the trunk 6.0 toolchain building 1.2.1 since the beginning of the month, which are not reproducible on trunk of this repo:

> .build/x86_64-unknown-linux-gnu/debug/swift-systemPackageTests.xctest SystemTests.FilePathComponentsTest/testAdHocRRC
Test Suite 'Selected tests' started at 2024-03-11 03:41:42.129
Test Suite 'FilePathComponentsTest' started at 2024-03-11 03:41:42.132
Test Case 'FilePathComponentsTest.testAdHocRRC' started at 2024-03-11 03:41:42.132
Swift/ArrayBufferProtocol.swift:175: Fatal error: invalid Collection: count differed in successive traversals

💣 Program crashed: Illegal instruction at 0x00007f2ea2f68f64

Thread 0 "swift-systemPac" crashed:                                                                                                                                
 0 0x00007f2ea2f68f64 closure #1 in closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:) + 308 in libswiftCore.so
 1 0x00007f2ea2f68d12 closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:) + 257 in libswiftCore.so                                                  2 0x00007f2ea2f68bcd closure #1 in _assertionFailure(_:_:file:line:flags:) + 380 in libswiftCore.so
 3 0x00007f2ea2f68756 _assertionFailure(_:_:file:line:flags:) + 229 in libswiftCore.so
 4 0x00007f2ea2f4e75b closure #1 in _ArrayBufferProtocol.replaceSubrange<A>(_:with:elementsOf:) + 266 in libswiftCore.so
 5 0x00007f2ea31d4136 partial apply for closure #1 in _ArrayBufferProtocol.replaceSubrange<A>(_:with:elementsOf:) + 37 in libswiftCore.so                           6 0x00007f2ea2fa5c53 Array.withContiguousStorageIfAvailable<A>(_:) + 50 in libswiftCore.so
 7 0x00007f2ea2f52599 Array.withContiguousStorageIfAvailable<A>(_:) + 8 in libswiftCore.so
 8 SystemString.withContiguousStorageIfAvailable<A>(_:) + 119 in swift-systemPackageTests.xctest at /home/fina/swift-system/Sources/System/SystemString.swift:149:31                                                                                                                                                                  
   147│     _ body: (UnsafeBufferPointer<SystemChar>) throws -> R
   148│   ) rethrows -> R? {
   149│     try nullTerminatedStorage.withContiguousStorageIfAvailable(body)
      │                               ▲
   150│   }
   151│

 9 0x00007f2ea2f5126f Array.replaceSubrange<A>(_:with:) + 638 in libswiftCore.so
10 SystemString.replaceSubrange<A>(_:with:) + 166 in swift-systemPackageTests.xctest at /home/fina/swift-system/Sources/System/SystemString.swift:136:27

   134│   ) where C.Element == SystemChar {
   135│     defer { _invariantCheck() }
   136│     nullTerminatedStorage.replaceSubrange(subrange, with: newElements)
      │                           ▲
   137│   }
   138│

11 FilePath.ComponentView.replaceSubrange<A>(_:with:) + 1182 in swift-systemPackageTests.xctest at /home/fina/swift-system/Sources/System/FilePath/FilePathComponentView.swift:172:20

   170│       str.append(platformSeparator)
   171│     }
   172│     _path._storage.replaceSubrange(range, with: str)
      │                    ▲
   173│   }
   174│ }
                                                                                                                                                                   12 0x00007f2ea2f57280 RangeReplaceableCollection.insert<A>(contentsOf:at:) + 639 in libswiftCore.so                                                                13 closure #4 in FilePathComponentsTest.testAdHocRRC() + 486 in swift-systemPackageTests.xctest at /home/fina/swift-system/Tests/SystemTests/FilePathTests/FilePathComponentsTest.swift:153:23

   151│
   152│     restoreAfter {
   153│       path.components.insert(
      │                       ▲
   154│         contentsOf: ["bar", "baz"], at: path.components.startIndex)
   155│       expect("/bar/baz/usr/local/bin")

14 restoreAfter #1 (body:) in FilePathComponentsTest.testAdHocRRC() + 132 in swift-systemPackageTests.xctest at /home/fina/swift-system/Tests/SystemTests/FilePathTests/FilePathComponentsTest.swift:125:7

   123│       let copy = path
   124│       defer { path = copy }
   125│       body()
      │       ▲
   126│     }
   127│
                                                                                                                                                                   15 FilePathComponentsTest.testAdHocRRC() + 237 in swift-systemPackageTests.xctest at /home/fina/swift-system/Tests/SystemTests/FilePathTests/FilePathComponentsTest.swift:152:5                                                                                                                                                       
   150│     }                                                                                                                                                         151│                                                                                                                                                               152│     restoreAfter {
      │     ▲                                                                                                                                                         153│       path.components.insert(                                                                                                                                 154│         contentsOf: ["bar", "baz"], at: path.components.startIndex)
                                                                                                                                                                   16 implicit closure #2 in implicit closure #1 in variable initialization expression of static FilePathComponentsTest.__allTests__FilePathComponentsTest + 26 in swift-systemPackageTests.xctest at /home/fina/swift-system/Tests/SystemTests/XCTestManifests.swift:42:26

    40│     // to regenerate.
    41│     static let __allTests__FilePathComponentsTest = [
    42│         ("testAdHocRRC", testAdHocRRC),                                                                                                                          │                          ▲                                                                                                                                     43│         ("testCases", testCases),
    44│         ("testSeparatorNormalization", testSeparatorNormalization),                                                                                                                                                                                                                                                           Backtrace took 0.27s
                                                                                                                                                                   Illegal instruction (core dumped)
> .build/x86_64-unknown-linux-gnu/debug/swift-systemPackageTests.xctest SystemTests.FilePathSyntaxTest/testAdHocMutations
Test Suite 'Selected tests' started at 2024-03-11 03:42:56.322                                                                                                     Test Suite 'FilePathSyntaxTest' started at 2024-03-11 03:42:56.326                                                                                                 Test Case 'FilePathSyntaxTest.testAdHocMutations' started at 2024-03-11 03:42:56.326                                                                               Swift/ArrayBufferProtocol.swift:175: Fatal error: invalid Collection: count differed in successive traversals                                                                                                                                                                                                                         💣 Program crashed: Illegal instruction at 0x00007f80b4768f64

Thread 0 "swift-systemPac" crashed:

 0 0x00007f80b4768f64 closure #1 in closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:) + 308 in libswiftCore.so                                    1 0x00007f80b4768d12 closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:) + 257 in libswiftCore.so
 2 0x00007f80b4768bcd closure #1 in _assertionFailure(_:_:file:line:flags:) + 380 in libswiftCore.so
 3 0x00007f80b4768756 _assertionFailure(_:_:file:line:flags:) + 229 in libswiftCore.so
 4 0x00007f80b474e75b closure #1 in _ArrayBufferProtocol.replaceSubrange<A>(_:with:elementsOf:) + 266 in libswiftCore.so
 5 0x00007f80b49d4136 partial apply for closure #1 in _ArrayBufferProtocol.replaceSubrange<A>(_:with:elementsOf:) + 37 in libswiftCore.so
 6 0x00007f80b47a5c53 Array.withContiguousStorageIfAvailable<A>(_:) + 50 in libswiftCore.so
 7 0x00007f80b4752599 Array.withContiguousStorageIfAvailable<A>(_:) + 8 in libswiftCore.so
 8 SystemString.withContiguousStorageIfAvailable<A>(_:) + 119 in swift-systemPackageTests.xctest at /home/fina/swift-system/Sources/System/SystemString.swift:149:31

   147│     _ body: (UnsafeBufferPointer<SystemChar>) throws -> R
   148│   ) rethrows -> R? {                                                                                                                                          149│     try nullTerminatedStorage.withContiguousStorageIfAvailable(body)
      │                               ▲                                                                                                                               150│   }                                                                                                                                                           151│                                                                                                                                                                                                                                                                                                                                9 0x00007f80b475126f Array.replaceSubrange<A>(_:with:) + 638 in libswiftCore.so
10 SystemString.replaceSubrange<A>(_:with:) + 166 in swift-systemPackageTests.xctest at /home/fina/swift-system/Sources/System/SystemString.swift:136:27

   134│   ) where C.Element == SystemChar {
   135│     defer { _invariantCheck() }
   136│     nullTerminatedStorage.replaceSubrange(subrange, with: newElements)
      │                           ▲
   137│   }
   138│

11 FilePath.extension.setter + 1286 in swift-systemPackageTests.xctest at /home/fina/swift-system/Sources/System/FilePath/FilePathSyntax.swift:343:16
                                                                                                                                                                      341│       ) ..< base._slice.endIndex
   342│
   343│       _storage.replaceSubrange(extRange, with: suffix)                                                                                                           │                ▲                                                                                                                                              344│     }
   345│   }                                                                                                                                                                                                                                                                                                                           12 closure #6 in FilePathSyntaxTest.testAdHocMutations() + 392 in swift-systemPackageTests.xctest at /home/fina/swift-system/Tests/SystemTests/FilePathTests/FilePathSyntaxTest.swift:946:22
                                                                                                                                                                      944│       path.append("ls")                                                                                                                                       945│       expect("/usr/local/bin/ls")                                                                                                                             946│       path.extension = "exe"
      │                      ▲                                                                                                                                        947│       expect("/usr/local/bin/ls.exe")                                                                                                                         948│       path.extension = "txt"                                                                                                                                                                                                                                                                                                  13 restoreAfter #1 (body:) in FilePathSyntaxTest.testAdHocMutations() + 132 in swift-systemPackageTests.xctest at /home/fina/swift-system/Tests/SystemTests/FilePathTests/FilePathSyntaxTest.swift:867:7                                                                                                                                                                                                                                                                                                    865│       let copy = path                                                                                                                                         866│       defer { path = copy }                                                                                                                                   867│       body()                                                                                                                                                     │       ▲                                                                                                                                                       868│     }                                                                                                                                                         869│                                                                                                                                                                                                                                                                                                                               14 FilePathSyntaxTest.testAdHocMutations() + 315 in swift-systemPackageTests.xctest at /home/fina/swift-system/Tests/SystemTests/FilePathTests/FilePathSyntaxTest.swift:943:5                                                                                                                                                         
   941│     }                                                                                                                                                         942│
   943│     restoreAfter {
      │     ▲
   944│       path.append("ls")
   945│       expect("/usr/local/bin/ls")

15 implicit closure #2 in implicit closure #1 in variable initialization expression of static FilePathSyntaxTest.__allTests__FilePathSyntaxTest + 26 in swift-systemPackageTests.xctest at /home/fina/swift-system/Tests/SystemTests/XCTestManifests.swift:62:32                                                                                                                                                                                                                                             60│     // to regenerate.                                                                                                                                          61│     static let __allTests__FilePathSyntaxTest = [
    62│         ("testAdHocMutations", testAdHocMutations),                                                                                                              │                                ▲                                                                                                                               63│         ("testFailableStringInitializers", testFailableStringInitializers),
    64│         ("testLexicallyRelative", testLexicallyRelative),

Backtrace took 0.16s

Illegal instruction (core dumped)

finagolfin avatar Mar 11 '24 03:03 finagolfin

We decided to insert a new interim release before these changes, which will use up the planned 1.3.0 version number. The changes originally targeting 1.3.0 will actually ship in 1.4.0, hopefully soon.

lorentey avatar May 09 '24 21:05 lorentey