swift-system icon indicating copy to clipboard operation
swift-system copied to clipboard

Add Sendable conformance to FileDescriptor

Open ffried opened this issue 3 years ago • 8 comments

This adds Sendable conformance to FileDescriptor alongside the other public types (see #115).

ffried avatar Oct 25 '22 12:10 ffried

I'd like to reengage with this topic. I'm still (even more) on the side of FileDescriptor being Sendable. @lorentey what would be the ABI impact of adding that conformance?

milseman avatar Jul 17 '23 17:07 milseman

Sendable has no ABI impact -- we can simply add the conformance whenever we are ready!

lorentey avatar Jul 18 '23 18:07 lorentey

@milseman @lorentey Should I change this PR to add the conformance (w/o marking it as unavailable)?

ffried avatar Jul 24 '23 09:07 ffried

Yes to adding it, deferring to @lorentey regarding availability.

milseman avatar Jul 24 '23 18:07 milseman

In accordance with the change in 87e68fc, I've updated the conformance to be on the main type. This also resolves the conflicts that existed on this PR's branch.

Depending on @lorentey's decision regarding availability, I'll move it to an extension again (for marking it unavailable).

ffried avatar Oct 10 '23 06:10 ffried