swift-syntax

swift-syntax copied to clipboard

ExpressionMacro trailing closure inherits code's original indentation

2

### Description If macro is nested in some closure, its trailing closure preserves the original code indentation. So if I build `FunctionCallExprSyntax` with trailing closure that takes statements from the...

InkyTsar

Required spacing is not added in `SwiftSyntaxBuilder` for interpolated syntax node

7

### Description For syntax nodes like `FunctionEffectSpecifiersSyntax` and `FunctionParameterSyntax`, some spacings are required internally. However, if a handcraft node is interpolated into another expression string, `SwiftSyntaxBuilder` fails to add these...

stevapple

`BasicFormat` indents closing `}` of closure passed as a function parameter

10

The following new test case fails. ```swift func testClosureParameter() { let source = """ myFunc({ return true }) """ assertFormatted(source: source, expected: source) } ``` The actual formatted source is...

ahoppen

Refactor `SyntaxClassifier` with `SyntaxVisitor`

1

A very early stage of the refactoring of `SyntaxClassifier`. Refactoring `SyntaxClassifier` with `SyntaxVisitor` makes it easier to maintain. We do not pass all the tests in `ClassificationTests` yet and we...

StevenWong12

Too much indentation in formatting of `AccessorDeclSyntax`

3

In the following two cases, we appear to add too much indentation in front of the `return`. ```swift let source: AccessorDeclSyntax = """ get { return 1 } """ assertFormatted(...

ahoppen

MacroSystem expansion detached nodes lose diagnostic context

4

### Description Macro expansions create diagnostics that are not relative to the given context (because they're `detached`), which means that there's no way to collocate diagnostics with the original source....

stephencelis

Improve SyntaxRewriter performance for operator folding

1

Running operator folding on MovieSwiftUI takes as long as parsing. That really shouldn’t be the case. Running with Instruments shows that we spend the majority of time in memory-related operations....

ahoppen

Add a high-level API to extract an argument from a `LabeledExprListSyntax`

2

A very common task for macros is to extract the argument for a specific function parameter. Instead of having each macro dig through the `LabeledExprListSyntax`, we should offer a high-level...

ahoppen

Document environment variables that can be used to modify swift-syntax’s build or test execution

5

We should have a single documentation document that describes all the environment variables that can be used to modify the behavior of Package.swift (e.g. `SWIFT_BUILD_SCRIPT_ENVIRONMENT`) and test execution (e.g. `SKIP_LONG_TESTS`)

ahoppen

Detect circular macro expansion in `MacroSystem`

1

The following recursive expansion of a macro causes an infinite loop in `MacroSystem`, which is used by `assertMacroExpansion`. The compiler diagnoses the circular evaluation of the macro. `MacroSystem` should do...

ahoppen