swift-syntax

swift-syntax copied to clipboard

`assertMacroExpansion` should emit an error if macro is applied to node that is not a variable

2

When applying an accessor macro to e.g. a struct, `assertMacroExpansion` will currently happily swallow the attribute. It should, however, emit an error that accessor macros can’t be applied to structs....

ahoppen

[SR-778] Forgetting the in keyword can sometimes lead to compiling code

13

| | | |------------------|-----------------| |Previous ID | SR-778 | |Radar | None | |Original Reporter | chriseidhof (JIRA User) | |Type | Bug | |Status | Reopened | |Resolution |...

swift-ci

Improve diagnostics for misspelt 'assocatedtype'

4

**Description** Almost everything in Swift uses camelCase. A notable exception is `associatedtype`. If a user happens to write `associatedType` in a protocol declaration we currently provide rather poor diagnostics, assuming...

karwa

Add arena to syntax nodes

2

Resolves #2036 Open this PR to start discussion and getting help when needed.

kimdv

[SR-8510] 'guard' is easy to misspell as 'gaurd', results in large number of follow-on errors, and could have a fixit.

9

| | | |------------------|-----------------| |Previous ID | SR-8510 | |Radar | rdar://problem/32419789 | |Original Reporter | @huonw | |Type | Bug | |Status | In Progress | |Resolution | |...

d4adc30e-df4b-4925-bfeb-69e631c0be69

[SR-11827] Missing "in" => bad diagnostic

3

| | | |------------------|-----------------| |Previous ID | SR-11827 | |Radar | rdar://problem/57418525 | |Original Reporter | @dabrahams | |Type | Bug | Additional Detail from JIRA | | | |------------------|-----------------|...

dabrahams

GroupedDiagnostics does not handle notes on diagnostics

2

### Description The `GroupedDiagnostics` formatter takes an array of `Diagnostic`s that it formats into a buffer. However, it only handles the top-level diagnostic messages, not any [attached notes](https://github.com/apple/swift-syntax/blob/main/Sources/SwiftDiagnostics/Diagnostic.swift#L30C3-L31C1)---which also have...

DougGregor

`BasicFormat` cannot indent closure body in tuple

1

### Description `BasicFormat` cannot indent the closure body when it's nested in a `LabeledExprSyntax`. ### Steps to Reproduce ```swift let builder = ExprSyntax( """ .init( name: { if let name...

stevapple

WIP: Make convenience initializers with CodeGeneration

6

## Summary **Work in progress, not ready for a full-on review, ideas and feedback welcome!** This pull request closes #1984. Instead of doing one-off initializers by hand, like in #2127...

natikgadzhi

Add initializer to `LabeledExprSyntax` that automatically adds a colon if the label exists

17

Currently, if you do the following ```swift let node = EnumCaseParameterSyntax(firstName: "label", type: TypeSyntax("MyType")) print(node.formatted()) ``` you get `label MyType`, which is surprising because the colon is missing and you...

ahoppen