swift-syntax icon indicating copy to clipboard operation
swift-syntax copied to clipboard
verified publisher icon apple

Improve diagnostics marked with TODO in `Tests/SwiftParser/translated`

Open ahoppen opened this issue 2 years ago • 15 comments

There are ~150 TODOs left in the test cases where diagnostics from the C++ parser are superior to the ones generated by SwiftParser. Those should be fixed.

Some of these TODOs are marked as “good first issue” and fixing those should be a good starting point to get started with the swift-syntax codebase.

Here’s a list of the tests that still have TODOs remaining. If you’ve got commit access to the repository and are working on one of them, mark them as ticked and add your named to assign them to you. If you don’t have commit access, comment on this issue and I’ll update the list to assign an issue to you.

  • [x] testAvailabilityQueryUnavailability34a @CippoX
  • [x] testDiagnoseAvailability17 @kimdv
  • [x] testDiagnoseAvailability20 @kimdv
  • [x] testDiagnoseAvailability21 @kimdv
  • [x] testEffectfulProperties12 @StevenWong12
  • [x] testEffectfulProperties13 @StevenWong12
  • [x] testIfconfigExpr17
  • [x] testIfconfigExpr22
  • [x] testIfconfigExpr24
  • [x] testIfconfigExpr25
  • [x] testIfconfigExpr27
  • [x] testIfconfigExpr28
  • [x] testIfconfigExpr30
  • [x] testOperatorDecl6 @StevenWong12
  • [x] testOperatorDecl7 @StevenWong12
  • [x] testOperatorDecl8 @StevenWong12
  • [ ] testOperatorDecl21 @StevenWong12
  • [ ] testRecovery17
  • [ ] testRecovery19
  • [ ] testRecovery23
  • [ ] testRecovery25
  • [ ] testRecovery28
  • [x] testRecovery49
  • [x] testRecovery63 (good first issue)
  • [x] testRecovery64 (good first issue)
  • [x] testRecovery98c @kimdv
  • [x] testRecovery98d @kimdv
  • [x] testRecovery98e @kimdv
  • [x] testRecovery98f @kimdv
  • [x] testRecovery98 @kimdv
  • [x] testRecovery99 @kimdv
  • [x] testRecovery100 @kimdv
  • [x] testRecovery10
  • [x] testRecovery102 @CippoX
  • [x] testRecovery103@CippoX
  • [x] testRecovery104@CippoX
  • [x] testRecovery110 @kimdv
  • [x] testRecovery121 @kimdv
  • [x] testRecovery125 @kimdv
  • [x] testRecovery126 @kimdv
  • [x] testRecovery127 @kimdv
  • [x] testRecovery128 @kimdv
  • [x] testRecovery129 @kimdv
  • [x] testRecovery130 @kimdv
  • [x] testRecovery131 @kimdv
  • [x] testRecovery136 @ahoppen
  • [x] testRecovery137 @ahoppen
  • [x] testRecovery151 @kimdv
  • [x] testRecovery153 @kimdv
  • [x] testRecovery157 @CippoX
  • [x] testRecovery163 @kimdv
  • [x] testRecovery164 @kimdv
  • [x] testRecovery165
  • [ ] testRecovery169
  • [x] testRecovery176 @kimdv
  • [x] testRecovery177 @kimdv
  • [x] testRecovery181
  • [ ] testTrailingClosures14

ahoppen avatar Mar 01 '23 14:03 ahoppen

rdar://106083939

ahoppen avatar Mar 01 '23 14:03 ahoppen

Hey @ahoppen, what are the additional codebase setup requirements apart from the swift-compiler setup which I already have, so I can start contributing to this repo too!

Rajveer100 avatar Mar 01 '23 17:03 Rajveer100

Hello! I'm currently working on testAvailabilityQuery34 in AvailabilityQueryTests.swift

Could I create a new issue and if there are few questions about this TODO? @ahoppen

bbvch13531 avatar Mar 02 '23 08:03 bbvch13531

Hi!

I'm looking into testIdentifiers7

kimdv avatar Mar 02 '23 08:03 kimdv

Hey @ahoppen, what are the additional codebase setup requirements apart from the swift-compiler setup which I already have, so I can start contributing to this repo too!

SwiftSyntax is (mostly) a standalone repo for which you don't need to build the Swift compiler yourself. You should be able to just open it in Xcode or in any other editor that supports LSP with SourceKit-LSP such as VSCode with the Swift Extension.

ahoppen avatar Mar 02 '23 16:03 ahoppen

To anyone who starts working on an issue, if you've gotten so far that you can open a PR (even if there are still things that don't work) we can use that to discuss further questions. If you need help before you've made any significant code changes, I agree that opening a new issues is a good way to keep the discussions focussed.

ahoppen avatar Mar 02 '23 16:03 ahoppen

Hi everyone, I'm working on testRecovery64

CippoX avatar Mar 17 '23 12:03 CippoX

@CippoX, @kimdv is already working on testRecovery64 here https://github.com/apple/swift-syntax/pull/1382

ahoppen avatar Mar 17 '23 17:03 ahoppen

@bbvch13531 are you still on testAvailabilityQuery34? Or is anyone looking into testAvailabilityQueryUnavailability28 or testAvailabilityQueryUnavailability34a?

CippoX avatar Mar 18 '23 11:03 CippoX

@CippoX

I don’t know of anyone working on testAvailabilityQueryUnavailability34a, if you want to take a look at that, that’d be great.

I suspect that testAvailabilityQueryUnavailability28 requires the same fix as testAvailabilityQuery34, so I’d like to see if @bbvch13531 is still working on it.

ahoppen avatar Mar 20 '23 17:03 ahoppen

Thank you @ahoppen, since @bbvch13531 didn't respond I've already made a pull request https://github.com/apple/swift-syntax/pull/1423, I'm also looking at testAvailabilityQueryUnavailability34a

CippoX avatar Mar 20 '23 18:03 CippoX

@CippoX, Oh, sorry, I didn’t see that PR yet while going through my emails. Thanks for creating it. 👍🏽

ahoppen avatar Mar 20 '23 20:03 ahoppen

Hi, I'm working on testRecovery176

CippoX avatar Mar 26 '23 20:03 CippoX

@CippoX I’m sorry @kimdv beat you to it: https://github.com/apple/swift-syntax/pull/1445

@kimdv Could you add comments here if you’re working on one of the TODOs to avoid these conflicts? It’s fine if you just have one comment and update that as well.

Edit: I changed my mind and am now keeping a list in the issue description. @kimdv Feel free to assign failing test cases to yourself if you want to.

ahoppen avatar Mar 27 '23 17:03 ahoppen

Thanks, we already solved it 👍

CippoX avatar Mar 27 '23 17:03 CippoX