swift-syntax icon indicating copy to clipboard operation
swift-syntax copied to clipboard

[DO NOT MERGE (YET)] `@ignoreDeprecations` attribute

Open NSAntoine opened this issue 3 years ago • 6 comments

NSAntoine avatar Oct 26 '22 12:10 NSAntoine

@hamishknight some git quirkiness happened here, anyways, is there anything more we have to do now in terms of the swift syntax repo?

NSAntoine avatar Oct 26 '22 12:10 NSAntoine

@hamishknight Looks good now?

NSAntoine avatar Oct 26 '22 15:10 NSAntoine

@hamishknight ^

NSAntoine avatar Oct 26 '22 17:10 NSAntoine

Do you have any idea how we would refer to subscripts in the attribute?

NSAntoine avatar Oct 28 '22 10:10 NSAntoine

Do you have any idea how we would refer to subscripts in the attribute?

IMO it would make sense to refer to them as x.subscript, this is not dissimilar to what we parse for e.g @available(*, deprecated, renamed: "subscript(y:)"). subscript cannot be used as an identifier on its own, it would require backticks, so it doesn't conflict with a function named subscript.

hamishknight avatar Nov 01 '22 11:11 hamishknight

Do you have any idea how we would refer to subscripts in the attribute?

IMO it would make sense to refer to them as x.subscript, this is not dissimilar to what we parse for e.g @available(*, deprecated, renamed: "subscript(y:)"). subscript cannot be used as an identifier on its own, it would require backticks, so it doesn't conflict with a function named subscript.

Sounds good!

NSAntoine avatar Nov 01 '22 11:11 NSAntoine