swift-openapi-urlsession icon indicating copy to clipboard operation
swift-openapi-urlsession copied to clipboard
verified publisher icon apple

Android support

Open marcprux opened this issue 9 months ago • 4 comments

Motivation

This package wasn't building on Android, causing various dependent packages to also fail to build.

Modifications

Add the necessary import(Android) to successfully build.

Result

The package can now be built for Android.

Test Plan

~~Added CI to build and run against an Android emulator using swift-android-action.~~

marcprux avatar Mar 29 '25 23:03 marcprux

How about if I remove the CI but leave in the fix for Lock.swift? It's just a one-line conditional import that will prevent build failures for dependent packages that are trying to build for Android. Similar PRs have been accepted by numerous other apple repos…

marcprux avatar Mar 31 '25 12:03 marcprux

How about if I remove the CI but leave in the fix for Lock.swift? It's just a one-line conditional import that will prevent build failures for dependent packages that are trying to build for Android. Similar PRs have been accepted by numerous other apple repos…

Yes please. Happy to take patches that fix Android!.

FranzBusch avatar Mar 31 '25 12:03 FranzBusch

I've removed the CI.

marcprux avatar Mar 31 '25 12:03 marcprux

@FranzBusch can you update your review? I'd prefer not to have to admin merge here :)

czechboy0 avatar Apr 01 '25 09:04 czechboy0

Thank you! 🙏 I just stumbled over this after also doing the exact same fix locally. It sounds like we could get this in as is and have a working version for Android?

diederich avatar Sep 10 '25 14:09 diederich

Yeah, it looks like everyone approved, so we just need to merge this 1-liner import fix. @FranzBusch or @simonjbeaumont, maybe?

marcprux avatar Sep 10 '25 15:09 marcprux