swift-openapi-generator icon indicating copy to clipboard operation
swift-openapi-generator copied to clipboard

[Generator] Add support of deepObject style in query params

Open arthurcro opened this issue 1 year ago • 6 comments

Motivation

The generator changes for: https://github.com/apple/swift-openapi-generator/issues/259

Depends on https://github.com/apple/swift-openapi-runtime/pull/100 landing first and getting released, and the version dependency being bumped here.

Modifications

Added deepObject style to serializer & parser in order to support nested keys on query parameters.

Result

Support nested keys on query parameters.

Test Plan

Adapted snippet tests (SnippetBasedReferenceTests)

arthurcro avatar Oct 24 '24 19:10 arthurcro

We discussed this offline, this is the PR https://github.com/apple/swift-openapi-generator/pull/538 reopened again, so that we can finish it up even while the original author is busy 🙂 Thanks @arthurcro for adding you both to the commit, it's important that we give credit to @kstefanou52 for the work already done!

czechboy0 avatar Oct 25 '24 07:10 czechboy0

Kicked off CI to see what state we're in.

czechboy0 avatar Oct 25 '24 07:10 czechboy0

Thank you for the review @czechboy0! I'll start taking a look at those changes asap! 🙂

arthurcro avatar Oct 25 '24 07:10 arthurcro

Sorry, I couldn’t find the time to complete this PR yet. I made some progress, but there seems to be an issue with the unit tests—possibly something with the runtime library. I’ll have some time this weekend, so if @arthurcro would like any help, please let me know.

kstefanou52 avatar Oct 25 '24 12:10 kstefanou52

Sorry, I couldn’t find the time to complete this PR yet. I made some progress, but there seems to be an issue with the unit tests—possibly something with the runtime library. I’ll have some time this weekend, so if @arthurcro would like any help, please let me know.

Thanks for the update @kstefanou52! I've got some availability this weekend too and would be happy to help . If you'd prefer to complete it yourself given the progress you've made, that's completely fine - just let me know what works best for you!

arthurcro avatar Oct 25 '24 19:10 arthurcro

Sorry, I couldn’t find the time to complete this PR yet. I made some progress, but there seems to be an issue with the unit tests—possibly something with the runtime library. I’ll have some time this weekend, so if @arthurcro would like any help, please let me know.

Thanks for the update @kstefanou52! I've got some availability this weekend too and would be happy to help . If you'd prefer to complete it yourself given the progress you've made, that's completely fine - just let me know what works best for you!

Thank you so much for the understanding @arthurcro. I'm just giving it a try and I will let you know about the outcome until Sunday end of the day.

kstefanou52 avatar Oct 26 '24 09:10 kstefanou52

Now that #538 landed, I'll close this.

czechboy0 avatar Jul 16 '25 08:07 czechboy0