swift-openapi-generator icon indicating copy to clipboard operation
swift-openapi-generator copied to clipboard
verified publisher icon apple

[GHA] Call the Soundness workflow

Open shinGangan opened this issue 1 year ago • 2 comments

Motivation

Observed all the workflows failed.

  • https://github.com/apple/swift-openapi-generator/actions

After examining the cause, the file name of the workflow used was changed. The PR where the file name has been changed is as follows.

  • apple/swift-nio#2789

Modifications

The file name has been changed to the correct one.

Also, benchmarks_linux_enabled was deleted in this PR. Therefore, with.benchmarks_linux_enabled was deleted.

Result

The workflow will move normally.

shinGangan avatar Jul 23 '24 17:07 shinGangan

Hi, swift-openapi-generator developer team 👋 Please review when the reviewer has time. 🙏

Thank you for your great work and development.

shinGangan avatar Jul 23 '24 17:07 shinGangan

@FranzBusch please lmk if this is good to go and I can kick off the CI and merge if all is green

czechboy0 avatar Jul 23 '24 20:07 czechboy0

Hello @FranzBusch , are there any additional changes to be made to this PR? If so, we will address them.

shinGangan avatar Sep 08 '24 12:09 shinGangan

@shinGangan This PR should probably be closed in favour of https://github.com/apple/swift-openapi-generator/pull/604

FranzBusch avatar Sep 09 '24 09:09 FranzBusch

Thanks for taking the time to help here @shinGangan. I'm closing this PR and I'm sorry about how long it took to get around to it and for the overlap between your work and Franz'. :)

simonjbeaumont avatar Sep 16 '24 19:09 simonjbeaumont

Hello @simonjbeaumont , thanks for your comment! I'll continue to contribute where I can. ;)

shinGangan avatar Sep 17 '24 04:09 shinGangan