swift-openapi-generator
swift-openapi-generator copied to clipboard
Use the same .swift-format in the repo and in the generated code
We use swift-format both for formatting the generator code, and the generated code. However, the configuration is duplicated in both places, we should have one source of truth for it instead.
I've opened a PR for this. Please have a look.
Well, this is good timing: https://github.com/apple/swift-package-manager/pull/6067
Unfortunately, it's only supported in Swift 5.9, so I propose we punt this issue until later, and adopt it when we bump the minimum tools version to 5.9.
Sounds good to me. So sometime in the fall when Xcode 15 comes out of beta I assume?
To be determined, but marking as blocked for now. You can close your other PR for now, but we'll definitely appreciate the contribution when Swift OpenAPI Generator requires Swift tools version 5.9!
Filed #75 to properly relate the two.
@czechboy0 if #75 is 1.0, can't this be under the same milestone as well?
@denil-ct the milestone doesn't mean when it'll land, it means which release it's blocking. It's likely this will land around the same time as #75, the milestone just means this wouldn't be considered a 1.0 blocker.
We don't use swift-format as a library anymore, so this is obsolete.