swift-numerics

swift-numerics copied to clipboard

BigInt Fixes for Issues in Violet Tests

8

This update fixes all known issues published by @LiarPrincess (see various pull requests for details) Improves the LosslessStringConvertible init() run time by 35X (radix 10) and 310X (radix 16). Improves...

mgriebling

Please read the [#242 Using tests from “Violet - Python VM written in Swift”](https://github.com/apple/swift-numerics/issues/242) before. --- Tests where we want to express things like: - `∀xab, (x+a)+b = x+(a+b)` -...

LiarPrincess

Please read the [#242 Using tests from “Violet - Python VM written in Swift”](https://github.com/apple/swift-numerics/issues/242) before. --- ## 🐰 Discussion - `bitWidth` - current implementation rounds up to nearest multiple of...

LiarPrincess

[BigInt] Using tests from “Violet - Python VM written in Swift”

5

This is a parent issue for merging `BigInt` tests from [Violet - Python VM written in Swift](https://github.com/LiarPrincess/Violet). In total is is about 400 tests (about 70% of Violet test cases)...

LiarPrincess

Improve String init() execution time and fix Violet bugs Pull request #262 addresses both these issues.

mgriebling

Please read the [#242 Using tests from “Violet - Python VM written in Swift”](https://github.com/apple/swift-numerics/issues/242) before. --- ## 💀 Crash ```Swift func test_initFromFloat_crash() { // 9223372036854775808 = UInt64(1)

LiarPrincess

[BigInt tests] ❌ Nodejs tests

1

Please read the [#242 Using tests from “Violet - Python VM written in Swift”](https://github.com/apple/swift-numerics/issues/242) before. --- Tests generated by [Node.js](https://nodejs.org/en/). It does require Node.js installed (obviously), but we could solve...

LiarPrincess

[BigInt tests] ✅ String tests

1

Please read the [#242 Using tests from “Violet - Python VM written in Swift”](https://github.com/apple/swift-numerics/issues/242) before. --- All pass. ## String parsing I think that `String` parsing performance can be improved....

LiarPrincess

[BigInt tests][No merge] 🐰 How NOT to write performance tests

3

Please read the [#242 Using tests from “Violet - Python VM written in Swift”](https://github.com/apple/swift-numerics/issues/242) before. --- === DO NOT MERGE! Discussion only. === ## 🐰 Discussion Those are the all...

LiarPrincess

[BigInt tests] 💀 Binary `*`, `/` and `%`

1

Please read the [#242 Using tests from “Violet - Python VM written in Swift”](https://github.com/apple/swift-numerics/issues/242) before. --- ## 💀 Crash ```Swift func test_div_crash() { let lhs = BigInt("-9223372036854775808")! let rhs =...

LiarPrincess