Support for Vision
Hi. In certain places like Source/NIOFileSystem/FileSystem there is:
#if os(macOS) || os(iOS) || os(tvOS) || os(watchOS) || os(Linux) || os(Android)
Can you please add os(visionOS) to this across the project. Thanks.
@glbrntt we should replace the Apple OSes with canImport(Darwin)
The #if os(...) guards in all of the file system code were to work around Swift System not knowing about visionOS (see: https://github.com/apple/swift-nio/pull/2636).
However, support for visionOS was added in Swift System 1.3.0.
I think the fix here should be to:
- remove the top-level
#if os(macOS) || os(iOS) || os(tvOS) || os(watchOS) || os(Linux) || os(Android)from the file system code, - bump the minimum version of swift-system required to 1.3.0
- remove the conditional dependency on swift-system from
Package.swift
In light of commit Issue-2900 - Add VisionOS support #2947, can this be closed or is further testing needed?
I think we can close this.