swift-nio icon indicating copy to clipboard operation
swift-nio copied to clipboard

Fix for Websocket client upgrade failure

Open agnosticdev opened this issue 1 year ago • 3 comments

Motivation:

Fix for issue-2631

Modifications:

Make sure the completion handler is sent in the upgrade failure path. Either in the expected or non-expected case.

Result:

Fix for both cases described in the issue.

agnosticdev avatar Feb 19 '24 21:02 agnosticdev

Rebased main to try to fix API Breakage check.

agnosticdev avatar Feb 19 '24 23:02 agnosticdev

It appears to have fixed the issue I was having in hummingbird-websocket. But yeah a local test would be a good idea.

adam-fowler avatar Feb 20 '24 11:02 adam-fowler

Added a unit test for this fix that validates that even if the update path did not succeed notUpgradingCompletionHandler should still be called.

agnosticdev avatar Feb 23 '24 22:02 agnosticdev