swift-nio icon indicating copy to clipboard operation
swift-nio copied to clipboard

docs: ClientBootstrap reuse is not important but permissible on the same thread/EL

Open weissi opened this issue 2 years ago • 7 comments

Motivation:

The original ClientBootstrap documentation is sometimes misunderstood as stressing the importance to re-use.

Modifications:

Explain that reuse is not important but permissible on the same thread/EL.

Result:

Clearer docs.

weissi avatar Sep 21 '23 19:09 weissi

it would be really great if we could suppress the DocC symbol link warnings, those cross-module/cross-package links work on Swiftinit!

tayloraswift avatar Sep 22 '23 14:09 tayloraswift

it would be really great if we could suppress the DocC symbol link warnings, those cross-module/cross-package links work on Swiftinit!

@franklinsch is this an option? Or will this work in DocC soon too?

Context is that I had to take out

``Sendable``

and

``EventLoop``

because it complained

weissi avatar Sep 22 '23 14:09 weissi

@weissi We're tracking cross-target link resolution with https://github.com/apple/swift-docc/issues/208. It's being worked on primarily by @d-ronnqvist

franklinsch avatar Oct 25 '23 10:10 franklinsch

@weissi We're tracking cross-target link resolution with apple/swift-docc#208. It's being worked on primarily by @d-ronnqvist

The initial support for cross-target linking in DocC is available on main behind a feature flag but the overall feature of multi-target documentation is still in progress.

Note that the planned—and currently implemented—syntax for linking to a symbol in another module is

``/OtherModuleName/SymbolName/functionName()``

stating with a leading / to indicate an external symbol link, followed by the absolute symbol path (including the name of the external module). For example:

  • /Swift/Sendable
  • /NIOCore/EventLoop

d-ronnqvist avatar Oct 25 '23 15:10 d-ronnqvist

@weissi We're tracking cross-target link resolution with apple/swift-docc#208. It's being worked on primarily by @d-ronnqvist

The initial support for cross-target linking in DocC is available on main behind a feature flag but the overall feature of multi-target documentation is still in progress.

Note that the planned—and currently implemented—syntax for linking to a symbol in another module is

``/OtherModuleName/SymbolName/functionName()``

stating with a leading / to indicate an external symbol link, followed by the absolute symbol path (including the name of the external module). For example:

  • /Swift/Sendable
  • /NIOCore/EventLoop

@dnadoba I assume NIO isn't using feature flags for its docs right now so this has to stay as is, correct?

weissi avatar Jan 03 '24 11:01 weissi

I'm not aware of any feature flags set for DocC in NIO. The two main way DocC is compiled is through the build system provided by https://swiftpackageindex.com/ and Xcodes "Product -> Build Documentation" action. I'm not aware of a safe way to add flags to both of them.

dnadoba avatar Jan 08 '24 14:01 dnadoba