swift-nio icon indicating copy to clipboard operation
swift-nio copied to clipboard

Fix stale hyperlinks in README

Open rayfix opened this issue 3 years ago • 18 comments

Fix broken hyperlinks in README

Motivation:

Fix broken hyperlinks in the README.

Modifications:

Changed the links pointing to the documentation of various protocols and classes. For Bootstrap-related links, centralize the definitions of the links so that they are easy to change if they break in the future. This follows the convention of the current document.

Result:

Links that resolve. 🥇

rayfix avatar Nov 02 '21 17:11 rayfix

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Can one of the admins verify this patch?

swift-server-bot avatar Nov 02 '21 17:11 swift-server-bot

Wow, the swift-server-bot seems really eager to get a review. Haha.

rayfix avatar Nov 03 '21 02:11 rayfix

Thanks for this patch!

The links aren't stale, they're actually too fresh. @tomerd, it seems like our docs haven't built in a while. Any idea what's going on?

Lukasa avatar Nov 03 '21 07:11 Lukasa

Ping @tomerd

Lukasa avatar Nov 18 '21 07:11 Lukasa

Ping @tomerd

Lukasa avatar Dec 10 '21 10:12 Lukasa

sorry about the delay @Lukasa, looks like SourceKitten is segfauling when trying to generate the docs. Will look into it

tomerd avatar Dec 10 '21 22:12 tomerd

https://github.com/apple/swift-nio/pull/2013

tomerd avatar Dec 16 '21 05:12 tomerd