swift-foundation icon indicating copy to clipboard operation
swift-foundation copied to clipboard

[android] fix the android build

Open hyp opened this issue 1 year ago • 11 comments

Macros can't yet be built as there's no host build support yet

hyp avatar Jul 23 '24 03:07 hyp

@swift-ci please test

hyp avatar Jul 23 '24 03:07 hyp

@swift-ci please test

hyp avatar Jul 23 '24 03:07 hyp

@swift-ci please test

hyp avatar Jul 23 '24 18:07 hyp

I think that we should consider #714 as an alternative here as that is a broader fix.

compnerd avatar Jul 25 '24 23:07 compnerd

This now drops the fts_open change - as posix_filesystem.apinotes are now picked up correctly : https://github.com/swiftlang/swift/pull/75494

hyp avatar Jul 26 '24 04:07 hyp

I think that we should consider https://github.com/apple/swift-foundation/pull/714 as an alternative here as that is a broader fix. @compnerd Good point, let me test that change for Android instead.

hyp avatar Jul 26 '24 04:07 hyp

@swift-ci please test

hyp avatar Jul 26 '24 04:07 hyp

@swift-ci please test

hyp avatar Jul 26 '24 16:07 hyp

Ok, macros work for android with:

https://github.com/compnerd/swift-foundation/pull/1 https://github.com/swiftlang/swift/pull/75549

If we land host macros first, we can drop this PR. wdyt @compnerd, or should this land first .

hyp avatar Jul 29 '24 19:07 hyp

I talked to @compnerd and I think we can hold off from this one, as the host macros changes should land soon.

hyp avatar Aug 05 '24 18:08 hyp

@hyp I think that this can be closed now?

compnerd avatar Aug 14 '24 03:08 compnerd