swift-foundation icon indicating copy to clipboard operation
swift-foundation copied to clipboard

Fix typos

Open Sajjon opened this issue 2 years ago • 7 comments

Fixes ~40 typos of which two where incorrect spellings of #if FOUNDATION_FRAMWORK.

I don't have Swift 5.9 toolchain setup, so I have not been able to run tests.

Sajjon avatar Apr 27 '23 07:04 Sajjon

Hi @Sajjon , I found another typo and created an issue here: https://github.com/apple/swift-foundation/issues/69

There's a canImport(Gibc) rather than Glibc.

I thought that since you already have this PR open, you could perhaps add a fix for that one too? :-)

mortenbekditlevsen avatar Apr 27 '23 10:04 mortenbekditlevsen

There's a canImport(Gibc) rather than Glibc.

I thought that since you already have this PR open, you could perhaps add a fix for that one too? :-)

I just noticed this typo before you commented and made a PR #70 to fix it in isolation. It's ok if we want to lump the fix in with this one too.

nathreed avatar Apr 27 '23 10:04 nathreed

@nathreed @mortenbekditlevsen thx, I included that typo in this PR as well now.

Sajjon avatar Apr 27 '23 10:04 Sajjon

@swift-ci please test

iCharlesHu avatar Apr 27 '23 14:04 iCharlesHu

@swift-ci test

parkera avatar Apr 27 '23 15:04 parkera

@shahmishal fixed the issue with the Linux CI; if we rebase this it'll pick up that fix

parkera avatar Apr 27 '23 16:04 parkera

@swift-ci test

shahmishal avatar Apr 28 '23 06:04 shahmishal