swift-foundation icon indicating copy to clipboard operation
swift-foundation copied to clipboard

Published 20 hours ago • verified publisher icon apple

Use a CShim to avoid an unescapable warning about using mktemp

Open parkera opened this issue 1 year ago • 10 comments

We work around the security issue with mktemp by checking for the existence of a conflict and retrying if necessary. The comment already in the source code explains why we can't use mkstemp. To avoid this warning appearing for every client of the package, work around it by adding a C shim before we call it.

parkera avatar Mar 18 '24 23:03 parkera

@swift-ci test

parkera avatar Mar 18 '24 23:03 parkera

@swift-ci test

parkera avatar Mar 20 '24 20:03 parkera

@swift-ci test

DougGregor avatar Mar 21 '24 15:03 DougGregor

Huh, the Linux one picked up yesterday's toolchain

DougGregor avatar Mar 21 '24 15:03 DougGregor

@swift-ci please test Linux

DougGregor avatar Mar 21 '24 15:03 DougGregor

@swift-ci please clean test Linux

DougGregor avatar Mar 21 '24 16:03 DougGregor

@swift-ci please test Linux

DougGregor avatar Mar 21 '24 20:03 DougGregor

Well, we got the new toolchain on Linux, but gold is failing to link on Linux

DougGregor avatar Mar 21 '24 21:03 DougGregor

@swift-ci test

parkera avatar Mar 28 '24 21:03 parkera

@swift-ci test

parkera avatar Jun 13 '24 16:06 parkera