swift-foundation icon indicating copy to clipboard operation
swift-foundation copied to clipboard

build: adopt current best practices for installation

Open compnerd opened this issue 10 months ago • 6 comments

Add the *_INSTALL_NESTED_SUBDIR option and use -print-target-info to compute the install locations. This reduces the number of times we need to invoke the compiler and compute these values.

compnerd avatar Mar 14 '25 00:03 compnerd

@swift-ci please test

compnerd avatar Mar 14 '25 00:03 compnerd

This is replicating what has been done with swift-testing, swift-corelibs-xctest, and is in the process of being applied to swift-corelibs-libdispatch as well.

compnerd avatar Mar 14 '25 00:03 compnerd

@swift-ci please test

compnerd avatar Mar 15 '25 15:03 compnerd

The change itself looks ok to me now - thanks for the explanations, but since this repo can't test CMake changes can you build a Linux + Windows toolchain via a cross-repo PR so that we can compare the toolchains and make sure that things still build and that they end up in the right places?

jmschonfeld avatar Mar 19 '25 18:03 jmschonfeld

@swift-ci please test

jmschonfeld avatar Mar 19 '25 18:03 jmschonfeld

Seems that the Linux toolchain build did uncover something. Will take a look once I clear up some more of the Windows patches.

compnerd avatar Mar 20 '25 21:03 compnerd