swift-distributed-tracing icon indicating copy to clipboard operation
swift-distributed-tracing copied to clipboard

Span.recordError should take optional SpanAttributes

Open slashmo opened this issue 4 years ago • 1 comments

The OTel specification states that Span’s recordException (in our case recordError) should take an additional argument to optionally specify SpanAttributes. These additional attributes (in case of OTel) are then merged into the resulting event’s attributes.

If RecordException is provided, the method MUST accept an optional parameter to provide any additional event attributes (this SHOULD be done in the same way as for the AddEvent method). If attributes with the same name would be generated by the method already, the additional attributes take precedence.

slashmo avatar Mar 14 '21 12:03 slashmo

Good catch!

ktoso avatar Mar 15 '21 08:03 ktoso