swift-distributed-actors icon indicating copy to clipboard operation
swift-distributed-actors copied to clipboard

Published 20 hours ago • verified publisher icon apple

Remove system._cluster as we have the clusterControl now

Open ktoso opened this issue 5 years ago • 1 comments

Follow up to https://github.com/apple/swift-distributed-actors/pull/89#issuecomment-530667606 or discussion

We should not need system._cluster as we should be able to do anything we want through the cluster control ;

Would solve a fixme we have now: let remoteControls = context.system._cluster!.associationRemoteControls // FIXME: should not be needed and use cluster members instead

ktoso avatar Sep 12 '19 05:09 ktoso

ClusterControl currently does not contain ClusterShell, as we are creating a deadLetter ClusterControl if clustering is not enabled and we can't create a ClusterShell without creating the actor. We could of course make the field in ClusterControl optional and handle sending to deadLetter directly, but then we would need to store a reference to deadLetters as well.

drexin avatar Sep 13 '19 20:09 drexin