swift-book icon indicating copy to clipboard operation
swift-book copied to clipboard

completing access modifiers example, by also adding open's default members access level.

Open deya-eldeen opened this issue 1 year ago • 3 comments

readers might be in doubt about the open access modifier, especially internal members, adding this part will explain this more and remove doubts.

we can remove some parts of it for brevity, but this line is important

var someInternalProperty = 0 // implicitly internal class member

deya-eldeen avatar Nov 14 '23 16:11 deya-eldeen

Thanks for starting this discussion! A couple issues that make this change a bit challenging to review:

  • The commit message should describe what you changed and why, not just restate which file contains the changes. (If you're editing on GitHub.com you need to replace the default message it gives you.)
  • The pull request should describe the problem in the current text. In this case, what are developers confused about? What incorrect conclusion are they likely to arrive at?
  • The pull request should describe why this solution resolves that problem. For example, here, why is it sufficient to add examples to the code? What about the prose nearby — does that need updates?

For more detailed guidance, please see CONTRIBUTING in this repository.

amartini51 avatar Nov 15 '23 21:11 amartini51

@deya-eldeen Is this a change you're still interested in making or advocating for? Or can I close this PR as "not to be merged"?

amartini51 avatar Jun 25 '24 22:06 amartini51

Still interested, I will provide details about this next week, hope this is ok.

Deya Eldeen Elkhawaldeh

On Wed, 26 Jun 2024 at 1:21 AM Alex Martini @.***> wrote:

@deya-eldeen https://github.com/deya-eldeen Is this a change you're still interested in making or advocating for? Or can I close this PR as "not to be merged"?

— Reply to this email directly, view it on GitHub https://github.com/apple/swift-book/pull/208#issuecomment-2190091088, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWPKQLEK5LAOCY7FULXLZDZJHUOXAVCNFSM6AAAAABJ4WKGT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJQGA4TCMBYHA . You are receiving this because you were mentioned.Message ID: @.***>

deya-eldeen avatar Jun 25 '24 22:06 deya-eldeen