swift-book icon indicating copy to clipboard operation
swift-book copied to clipboard

Add a "Make a contribution" banner on footer or header

Open Kyle-Ye opened this issue 1 year ago • 7 comments

Description

To facilitate contributions, I recommend adding a "Make a contribution" banner or button to the header or footer of each page. This will allow users to easily submit pull requests if they notice any errors on that particular page. Clicking the banner/button will take them directly to the source file for that page with edit mode enabled.

For instance, if a user clicks on the "Make a contribution" banner while viewing the-swift-programming-language/aboutswift, they will be redirected to https://github.com/apple/swift-book/edit/main/TSPL.docc/GuidedTour/AboutSwift.md.

image

Motivation

Github's Open Source Doc Workflow

https://docs.github.com/

image

Kyle-Ye avatar Mar 14 '23 11:03 Kyle-Ye

@Kyle-Ye it is a easy issue for new comer . Can you assign this to me?

nakul1710 avatar May 19 '23 18:05 nakul1710

@nakul1710 Please feel free to make a pull request against DocC to add support for this behavior, and then open a pull request against TSPL to adopt the new behavior. You don't need to wait for someone else to assign the issue to you.

If your approach is complex, you can pitch it on the forums to get feedback about potential issues before you invest a lot of time programming.

amartini51 avatar May 19 '23 20:05 amartini51

Please feel free to make a pull request against DocC to add support for this behavior, and then open a pull request against TSPL to adopt the new behavior. You don't need to wait for someone else to assign the issue to you.

If your approach is complex, you can pitch it on the forums to get feedback about potential issues before you invest a lot of time programming.

Sorry, I do not have the permission to make an assign in this repo.

You can follow amartini51's suggestion to try it directly.

Kyle-Ye avatar May 20 '23 02:05 Kyle-Ye

can you give me some pointers ? i am new here

nakul1710 avatar May 20 '23 04:05 nakul1710

@Kyle-Ye can you assign this to me

nakul1710 avatar Jul 08 '23 16:07 nakul1710

@Kyle-Ye can you assign this to me

I do not have the permission to make an assign in this repo. Maybe you should ask amartini51.

Kyle-Ye avatar Jul 08 '23 17:07 Kyle-Ye

@nakul1710 Please see my comments from May 19 above. I suggest you make a PR with your suggested changes in the Swift-DocC repository, and in this repository.

amartini51 avatar Jul 10 '23 16:07 amartini51