servicetalk icon indicating copy to clipboard operation
servicetalk copied to clipboard

Published 20 hours ago • verified publisher icon apple

Offload calls to ServiceDiscovererFilter

Open lewisd32 opened this issue 6 years ago • 1 comments

Since we were not adding filters before for ServiceDiscoverer and we assumed that we will write ServiceDiscoverer and LoadBalancer (consume of SD stream) implementations, we chose to not offload the Publisher returned from discover(). Now with filters there is a higher possibility for user code being added in this path and hence a potential to block the eventloop. So, we should be adding offloading for these calls.

lewisd32 avatar Feb 05 '19 16:02 lewisd32

Originating discussion: https://github.com/servicetalk/servicetalk/pull/283#discussion_r253653085

NiteshKant avatar Feb 05 '19 17:02 NiteshKant