servicetalk icon indicating copy to clipboard operation
servicetalk copied to clipboard

Move abstract TCK classes to testFixtures to use in other modules

Open idelpivnitskiy opened this issue 3 years ago • 0 comments

Motivation:

We have a few internal operators for liftSync or liftSyncToSingle in other modules that currently not tested with RS TCK.

Modifications:

  • Move Abstract*TckTest classes to testFixtures, make their public methods protected, add javadoc;
  • Add missing @Test annotation for implementations of those abstract tests;
  • Use new servicetalk-concurrent-reactivestreams-testFixtures for SpliceFlatStreamToMetaSingle and BeforeFinallyHttpOperator;
  • Fix violation of 1.09 rule found in SpliceFlatStreamToMetaSingle;
  • Temporarily skip testing 3.13 rule for BeforeFinallyHttpOperator;

Result:

Our internal operators can be tested with RS TCK.

idelpivnitskiy avatar Aug 11 '22 17:08 idelpivnitskiy