pkl icon indicating copy to clipboard operation
pkl copied to clipboard

For the pkl CLI, please provide an installer package for Homebrew

Open ujay68 opened this issue 1 year ago • 6 comments

Subject says all.

Homebrew (https://brew.sh/) is a very popular package manager for macOS where you can find almost any tool you might ever want to install.

ujay68 avatar Feb 03 '24 17:02 ujay68

We already started the process of releasing Pkl to homebrew. Should come soon.

stackoverflow avatar Feb 03 '24 18:02 stackoverflow

Submitted here: https://github.com/Homebrew/homebrew-core/pull/161655

Looks like we need to re-submit as a cask.

bioball avatar Feb 03 '24 19:02 bioball

Great. Thank you!

ujay68 avatar Feb 03 '24 19:02 ujay68

I don't think cask is the right approach, something like the below should work

class Pkl < Formula
  desc "Configuration as code language with rich validation and tooling"
  homepage "https://pkl-lang.org"
  url "https://github.com/apple/pkl/archive/refs/tags/0.25.1.tar.gz"
  sha256 "f60412679a9a8a1740e81cbed89a3ca9ddc9aa2cf0c487ff8a8a9fce70c0bf4a"
  license "Apache-2.0"

  depends_on "openjdk@17" => :build

  def install
    ENV["JAVA_HOME"] = Formula["openjdk@17"].opt_prefix
    task_os = OS.mac? ? "mac" : "linux"
    task_arch = Hardware::CPU.arm? ? "Aarch64" : "Amd64"
    task_name = ":pkl-cli:#{task_os}Executable#{task_arch}"

    system "git", "apply", "patches/graalVm23.patch" if OS.mac? && Hardware::CPU.arm?

    system "./gradlew", task_name
    os = OS.mac? ? "macos" : "linux"
    arch = Hardware::CPU.arm? ? "aarch64" : "amd64"
    bin.install "pkl-cli/build/executable/pkl-#{os}-#{arch}" => "pkl"
  end
end

However, the problem I am having is with homebrew's shimmed cc. It is expecting the environment variable HOMEBREW_RUBY_PATH to be present, and something is wiping out that value in the task process before the cc invocation. I tried to see where it was getting removed from the environment but was unable to figure it out

austinarbor avatar Feb 05 '24 00:02 austinarbor

It looks like the submission has been stalled on the Homebrew side, is that the status?

mattpackwood avatar Feb 20 '24 14:02 mattpackwood

It looks like the submission has been stalled on the Homebrew side, is that the status?

there is a new submission https://github.com/Homebrew/homebrew-core/pull/162857

pavelzw avatar Feb 20 '24 14:02 pavelzw

@pavelzw It looks like you (we) are just waiting for someone to approve the merge?

mattpackwood avatar Feb 24 '24 15:02 mattpackwood

Yeah, right now we are waiting for a homebrew maintainer to approve and merge the PR.

bioball avatar Feb 26 '24 20:02 bioball

This is now available on homebrew! brew install pkl will install the CLI.

We are adding instructions to our website in https://github.com/apple/pkl/pull/270.

bioball avatar Feb 29 '24 18:02 bioball