llvm-project icon indicating copy to clipboard operation
llvm-project copied to clipboard

Check for null oso SymbolFile in SymbolFileDwarfDebugMap::ResolveSymb…

Open jimingham opened this issue 10 months ago • 1 comments

…olContext (#89324)

The couple other places that use the oso module's SymbolFile, they check that it's non-null, so this is just an oversight in ResolveSymbolContext.

I didn't add a test for this (but did add a log message for the error case) because I can't see how this would actually happen. The .o file had to have valid enough DWARF that the linker's parser could handle it or it would not be in the debug map. If you delete the .o file, we just leave that entry out of the debug map. If you strip it or otherwise mess with it, we'll notice the changed mod time and refuse to read it...

This was based on a report from the field, and we don't have access to the project. But if the logging tells me how this happened I can come back and add a test with that example.

(cherry picked from commit 6b3893690b37d6e85cabfd144eca9a738e3baf9b)

jimingham avatar Apr 19 '24 00:04 jimingham

@swift-ci test

JDevlieghere avatar Apr 19 '24 00:04 JDevlieghere